From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v2 4/4] tools/build: change order of config/Tools.mk inclusion Date: Tue, 22 May 2012 15:48:25 +0100 Message-ID: <4FBBA739.7020706@citrix.com> References: <1337256990-51913-1-git-send-email-roger.pau@citrix.com> <1337256990-51913-4-git-send-email-roger.pau@citrix.com> <20406.12213.751409.867469@mariner.uk.xensource.com> <4FB632A6.4000403@citrix.com> <20406.13989.715688.280631@mariner.uk.xensource.com> <4FB639B3.3000905@citrix.com> <20406.20226.542693.284753@mariner.uk.xensource.com> <4FB657C2.8090007@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FB657C2.8090007@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Christoph Egger Cc: Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Christoph Egger wrote: > On 05/18/12 15:30, Ian Jackson wrote: > >> Roger Pau Monne writes ("Re: [PATCH v2 4/4] tools/build: change order of config/Tools.mk inclusion"): >>> Ian Jackson wrote: >>>> I know that. But given that the configure is just for the tools >>>> build, should we honour PREFIX from Config.mk (and ./.config or >>>> command line arguments) or from ./configure ? >>> I think the one from configure, since we have a configure script, better >>> make use of it, that is what users expect. >> I guess so. >> >>> I will resend this patch with the above changes to config/Linux.mk, >>> is that ok? >> I don't think prefixing paths in /var with PREFIX is ever right. >> Overriding it in Linux.mk seems like a band-aid. > > > One suggestion: > > Move all path variables out of config/*.mk and let configure generate > a config/paths.mk. What should we do about this? Should I try to fix StdGNU.mk/Linux.mk/NetBSD.mk or are we going to move all paths from config/*.mk and put them in a single file generated by configure?