From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: libxl: cannot start guest Date: Tue, 22 May 2012 17:32:21 +0200 Message-ID: <4FBBB185.8030005@amd.com> References: <4FB64BDC.6010801@amd.com> <1337347821.22316.122.camel@zakaz.uk.xensource.com> <4FB65B61.7000902@amd.com> <4FB66FED.5080704@amd.com> <1337356698.22316.138.camel@zakaz.uk.xensource.com> <4FBA185A.3080306@amd.com> <1337602541.24660.105.camel@zakaz.uk.xensource.com> <4FBA3EC8.3060104@amd.com> <1337608191.24660.138.camel@zakaz.uk.xensource.com> <4FBA62F7.9080308@gmx.de> <1337615835.24660.169.camel@zakaz.uk.xensource.com> <4FBB882B.1020902@amd.com> <1337691225.10118.114.camel@zakaz.uk.xensource.com> <4FBB9228.70001@gmx.de> <1337692887.10118.127.camel@zakaz.uk.xensource.com> <4FBB9C9F.4090401@amd.com> <1337696422.10118.134.camel@zakaz.uk.xensource.com> <4FBBADC2.7000904@amd.com> <1337700078.10118.141.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090801040304010603040304" Return-path: In-Reply-To: <1337700078.10118.141.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Daniel De Graaf , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --------------090801040304010603040304 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On 05/22/12 17:21, Ian Campbell wrote: > On Tue, 2012-05-22 at 16:16 +0100, Christoph Egger wrote: >> On 05/22/12 16:20, Ian Campbell wrote: >>> All the >= checks on *xcg_handle seem wrong to me. Really they should be >>> checking != NULL, since otherwise they don't actually discriminate the >>> two cases! Does making that change help? >> >> Yes, that helps! I can start guests again. > > Excellent, I assume you are going to submit the patch (i.e. I don't need > to..) Yes, patch attached. Fix pointer checks introduced in changeset 24757:aae516b78fce. This fixes xenstored crash on platforms with no gnttap implementation. Signed-off-by: Christoph Egger -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --------------090801040304010603040304 Content-Type: text/plain; charset="us-ascii"; name="xen_tools_xenstore.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xen_tools_xenstore.diff" Content-Description: xen_tools_xenstore.diff ZGlmZiAtciA5OTI2MzEzMjY2NWIgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5j Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwlGcmkgTWF5IDE4IDEy OjM4OjU1IDIwMTIgKzAyMDAKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFp bi5jCVR1ZSBNYXkgMjIgMTc6MjU6MDMgMjAxMiArMDIwMApAQCAtMTY3LDcgKzE2Nyw3IEBA IHN0YXRpYyBpbnQgcmVhZGNobihzdHJ1Y3QgY29ubmVjdGlvbiAqY28KIAogc3RhdGljIHZv aWQgKm1hcF9pbnRlcmZhY2UoZG9taWRfdCBkb21pZCwgdW5zaWduZWQgbG9uZyBtZm4pCiB7 Ci0JaWYgKCp4Y2dfaGFuZGxlID49IDApIHsKKwlpZiAoKnhjZ19oYW5kbGUgIT0gTlVMTCkg ewogCQkvKiB0aGlzIGlzIHRoZSBwcmVmZXJyZWQgbWV0aG9kICovCiAJCXJldHVybiB4Y19n bnR0YWJfbWFwX2dyYW50X3JlZigqeGNnX2hhbmRsZSwgZG9taWQsCiAJCQlHTlRUQUJfUkVT RVJWRURfWEVOU1RPUkUsIFBST1RfUkVBRHxQUk9UX1dSSVRFKTsKQEAgLTE3OSw3ICsxNzks NyBAQCBzdGF0aWMgdm9pZCAqbWFwX2ludGVyZmFjZShkb21pZF90IGRvbWlkCiAKIHN0YXRp YyB2b2lkIHVubWFwX2ludGVyZmFjZSh2b2lkICppbnRlcmZhY2UpCiB7Ci0JaWYgKCp4Y2df aGFuZGxlID49IDApCisJaWYgKCp4Y2dfaGFuZGxlICE9IE5VTEwpCiAJCXhjX2dudHRhYl9t dW5tYXAoKnhjZ19oYW5kbGUsIGludGVyZmFjZSwgMSk7CiAJZWxzZQogCQltdW5tYXAoaW50 ZXJmYWNlLCBnZXRwYWdlc2l6ZSgpKTsK --------------090801040304010603040304 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --------------090801040304010603040304--