From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Date: Wed, 30 May 2012 10:31:41 -0700 Message-ID: <4FC6597D.4060204@zytor.com> References: <1338383402-3838-1-git-send-email-andre.przywara@amd.com> <4FC63DAF0200007800086DC5@nat28.tlf.novell.com> <4FC62888.9010407@amd.com> <20120530144851.GA12184@jshin-Toonie> <20120530145005.GI3207@phenom.dumpdata.com> <20120530150334.GA13349@jshin-Toonie> <20120530171754.GA5115@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120530171754.GA5115@phenom.dumpdata.com> Sender: linux-kernel-owner@vger.kernel.org To: Konrad Rzeszutek Wilk Cc: Jacob Shin , Andre Przywara , jeremy@goop.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Jan Beulich , mingo@elte.hu, tglx@linutronix.de List-Id: xen-devel@lists.xenproject.org On 05/30/2012 10:17 AM, Konrad Rzeszutek Wilk wrote: >> Yes, the following patch also fixed the crash for us: >> >> Implement rdmsr_regs and wrmsr_regs for Xen pvops. > > That needs more data. Such as the reason for it, the crash > tombstone, and an analysis of the bug. > > But at this point I am not sure what we are going to do. > > I think Peter leans towards ripping the .rdmsr_regs/wdmsr_regs > function out altogether (so altering the amd_rdmsr... to use the > .rdmsr/.wrdmsr). At which point I think this would all work > just fine? > No, you can't just do that. Rip them out as in trap and emulate. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.