From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Date: Wed, 30 May 2012 11:00:23 -0700 Message-ID: <4FC66037.6020506@zytor.com> References: <1338383402-3838-1-git-send-email-andre.przywara@amd.com> <4FC63DAF0200007800086DC5@nat28.tlf.novell.com> <4FC62888.9010407@amd.com> <20120530144851.GA12184@jshin-Toonie> <20120530145005.GI3207@phenom.dumpdata.com> <20120530150334.GA13349@jshin-Toonie> <20120530171754.GA5115@phenom.dumpdata.com> <20120530173247.GC15635@x1.osrc.amd.com> <4FC65D34.1060803@zytor.com> <20120530175150.GE15438@x1.osrc.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120530175150.GE15438@x1.osrc.amd.com> Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov , Konrad Rzeszutek Wilk , Jacob Shin , Andre Przywara , jeremy@goop.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Jan Beulich , mingo@elte.hu, tglx@linutronix.de List-Id: xen-devel@lists.xenproject.org On 05/30/2012 10:51 AM, Borislav Petkov wrote: > On Wed, May 30, 2012 at 10:47:32AM -0700, H. Peter Anvin wrote: >>> I wouldn't do that. Andre's patch switches to the >>> rdmsrl_safe/checking_wrmsrl functions so you don't need to implement the >>> _regs functions for pvops. >>> >> But we just stated - it is wrong for K8? > > Not executed on K8 - only on F15h, models 0x10 - 0x1f. > OK. But there is still the general problem, no? -hpa