From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 4 of 5 V2] libxl: move
	libxl__sched_set_params into libxl.c
Date: Thu, 31 May 2012 14:48:18 +0100
Message-ID: <4FC776A2.4080200@eu.citrix.com>
References: <patchbomb.1338299818@cosworth.uk.xensource.com>
	<d89b5eeb94519fdc056f.1338299822@cosworth.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <d89b5eeb94519fdc056f.1338299822@cosworth.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Juergen Gross <juergen.gross@ts.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 29/05/12 14:57, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell<ian.campbell@citrix.com>
> # Date 1338299813 -3600
> # Node ID d89b5eeb94519fdc056f91663676cf012c40b654
> # Parent  274de8e1e0d116070d34731d93b53ce44530e5a0
> libxl: move libxl__sched_set_params into libxl.c
>
> All the other sched functions are here and I'm just about to make those static
> functions as I make libxl__sched_set_params the public function.
>
> Signed-off-by: Ian Campbell<ian.campbell@citrix.com>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
>
> diff -r 274de8e1e0d1 -r d89b5eeb9451 tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c	Tue May 29 14:55:29 2012 +0100
> +++ b/tools/libxl/libxl.c	Tue May 29 14:56:53 2012 +0100
> @@ -3450,6 +3450,33 @@ int libxl_sched_sedf_domain_set(libxl_ct
>       return 0;
>   }
>
> +int libxl__sched_set_params(libxl__gc *gc, uint32_t domid,
> +                            libxl_domain_sched_params *scparams)
> +{
> +    libxl_scheduler sched = scparams->sched;
> +    int ret;
> +
> +    if (sched == LIBXL_SCHEDULER_UNKNOWN)
> +        sched = libxl__domain_scheduler(gc, domid);
> +
> +    switch (sched) {
> +    case LIBXL_SCHEDULER_SEDF:
> +        ret=libxl_sched_sedf_domain_set(CTX, domid, scparams);
> +        break;
> +    case LIBXL_SCHEDULER_CREDIT:
> +        ret=libxl_sched_credit_domain_set(CTX, domid, scparams);
> +        break;
> +    case LIBXL_SCHEDULER_CREDIT2:
> +        ret=libxl_sched_credit2_domain_set(CTX, domid, scparams);
> +        break;
> +    default:
> +        LOG(ERROR, "Unknown scheduler");
> +        ret=ERROR_INVAL;
> +        break;
> +    }
> +    return ret;
> +}
> +
>   int libxl_send_trigger(libxl_ctx *ctx, uint32_t domid,
>                          libxl_trigger trigger, uint32_t vcpuid)
>   {
> diff -r 274de8e1e0d1 -r d89b5eeb9451 tools/libxl/libxl_dom.c
> --- a/tools/libxl/libxl_dom.c	Tue May 29 14:55:29 2012 +0100
> +++ b/tools/libxl/libxl_dom.c	Tue May 29 14:56:53 2012 +0100
> @@ -42,33 +42,6 @@ libxl_domain_type libxl__domain_type(lib
>           return LIBXL_DOMAIN_TYPE_PV;
>   }
>
> -int libxl__sched_set_params(libxl__gc *gc, uint32_t domid,
> -                            libxl_domain_sched_params *scparams)
> -{
> -    libxl_scheduler sched = scparams->sched;
> -    int ret;
> -
> -    if (sched == LIBXL_SCHEDULER_UNKNOWN)
> -        sched = libxl__domain_scheduler(gc, domid);
> -
> -    switch (sched) {
> -    case LIBXL_SCHEDULER_SEDF:
> -        ret=libxl_sched_sedf_domain_set(CTX, domid, scparams);
> -        break;
> -    case LIBXL_SCHEDULER_CREDIT:
> -        ret=libxl_sched_credit_domain_set(CTX, domid, scparams);
> -        break;
> -    case LIBXL_SCHEDULER_CREDIT2:
> -        ret=libxl_sched_credit2_domain_set(CTX, domid, scparams);
> -        break;
> -    default:
> -        LOG(ERROR, "Unknown scheduler");
> -        ret=ERROR_INVAL;
> -        break;
> -    }
> -    return ret;
> -}
> -
>   int libxl__domain_shutdown_reason(libxl__gc *gc, uint32_t domid)
>   {
>       libxl_ctx *ctx = libxl__gc_owner(gc);