From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] Fix pygrub install. Date: Fri, 1 Jun 2012 11:35:59 +0100 Message-ID: <4FC89B0F.5090407@eu.citrix.com> References: <1338397005-7051-1-git-send-email-anthony.perard@citrix.com> <1338539390.17466.26.camel@zakaz.uk.xensource.com> <4FC89556.7090502@eu.citrix.com> <4FC8979A.6000700@citrix.com> <1338546648.17466.72.camel@zakaz.uk.xensource.com> <4FC89ADF.6080503@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FC89ADF.6080503@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: Anthony Perard , Ian Campbell , Xen Devel List-Id: xen-devel@lists.xenproject.org On 01/06/12 11:35, Roger Pau Monne wrote: > Ian Campbell wrote: >> On Fri, 2012-06-01 at 11:21 +0100, Roger Pau Monne wrote: >>> George Dunlap wrote: >>>> On 01/06/12 09:29, Ian Campbell wrote: >>>>> On Thu, 2012-05-31 at 10:54 +0100, Anthony PERARD wrote: >>>>>> On Thu, May 31, 2012 at 10:42 AM, George Dunlap >>>>>> wrote: >>>>>>> The strange thing is that there *is* a pygrub in the right place, so >>>>>>> it appears that thefollowing line ($INSTALL_PYTHON_PROG) is redundant? >>>>>> It's seems that the right on the script are already set to 755 by the >>>>>> setup.py, so this $INSTALL_PYTHON_PROG line is probably an extra. >>>>> What is the conclusion here? Is the original patch correct and/or is >>>>> there a subsequent additional fix? >>>> There is a bug (pygrub is installed both in $(DESTDIR)/foo and >>>> $(DESTDIR)/$(DESTDIR)/foo), and Anthony's first patch (AFAICT) correctly >>>> fixes the bug (only installed in $(DESTDIR). >>>> >>>> I think there is a redundant command in the Makefile as well, where >>>> pygrub will be copied to $(DESTDIR)/foo twice. That doesn't cause >>>> incorrect behavior, but I would probably still consider it a bug. >>> I get an error when performing an install-tools on NetBSD: >>> >>> byte-compiling /usr/xen42/lib/python2.7/site-packages/grub/LiloConf.py >>> to LiloConf.pyc >>> running install_scripts >>> copying build/scripts-2.7/pygrub -> //usr/xen42/bin >>> error: //usr/xen42/bin/pygrub: Too many levels of symbolic links >> OOI what does //usr/xen42/bin/pygrub point to? > lrwxr-xr-x 1 root wheel 21 May 25 14:32 //usr/xen42/bin/pygrub -> > /usr/xen42/bin/pygrub > >>> gmake[3]: *** [install] Error 1 >>> gmake[3]: Leaving directory `/root/xen/xen-clean/tools/pygrub' >>> gmake[2]: *** [subdir-install-pygrub] Error 2 >>> gmake[2]: Leaving directory `/root/xen/xen-clean/tools' >>> gmake[1]: *** [subdirs-install] Error 2 >>> gmake[1]: Leaving directory `/root/xen/xen-clean/tools' >>> gmake: *** [install-tools] Error 2 >>> >>> Which I'm quite sure is caused by this. >> "this" == this problem or "this" == this patch? > I haven't tried the patch, I was referring to the current code in the > repository, so this == this problem. Ah, but that must be a different problem -- is it perhaps the case that in NetBSD $(PRIVATE_BINDIR) and $(BINDIR) are the same? -George