From: George Dunlap <george.dunlap@eu.citrix.com>
To: Tim Deegan <tim@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1 of 4 RFC] xen, p2m: get_entry returns level of entry as well
Date: Thu, 14 Jun 2012 16:01:03 +0100 [thread overview]
Message-ID: <4FD9FCAF.4050002@eu.citrix.com> (raw)
In-Reply-To: <20120614102116.GH82539@ocelot.phlegethon.org>
On 14/06/12 11:21, Tim Deegan wrote:
> At 12:54 +0100 on 08 Jun (1339160091), George Dunlap wrote:
>> Return the p2m level of the entry which filled this request.
>> Intended to be used to see if pages returned by the balloon
>> driver are part of a superpage, and reclaim them if so.
> This looks broadly correct, but it's a bit invasive. If there's any way
> to rework patch 2 not to need it that would be helpful. It looks like
> the main use is for detecting and removing superpage PoD entries; maybe
> that could be done with a sweep like you have in the non-PoD case?
You mean the non-balloon case? I forget why I thought that was a bad
idea, exactly. Let me think about that.
> One niggle: returning level=5 on error is non-obvious, and it doesn't
> look like your code in patch 2 uses that.
Were you thinking -1 or something like that?
-George
next prev parent reply other threads:[~2012-06-14 15:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 11:54 [PATCH 0 of 4 RFC] Populate-on-demand: Check pages being returned by the balloon driver George Dunlap
2012-06-08 11:54 ` [PATCH 1 of 4 RFC] xen, p2m: get_entry returns level of entry as well George Dunlap
2012-06-14 10:21 ` Tim Deegan
2012-06-14 15:01 ` George Dunlap [this message]
2012-06-14 15:31 ` Tim Deegan
2012-06-14 16:39 ` George Dunlap
2012-06-14 17:00 ` Tim Deegan
2012-06-08 11:54 ` [PATCH 2 of 4 RFC] xen, pod: Check zero-check pages returned by the balloon driver George Dunlap
2012-06-14 10:28 ` Tim Deegan
2012-06-14 12:57 ` Andres Lagar-Cavilla
2012-06-14 13:19 ` Tim Deegan
2012-06-14 13:19 ` Olaf Hering
2012-06-14 13:20 ` Tim Deegan
2012-06-08 11:54 ` [PATCH 3 of 4 RFC] imported patch CA-72761-libxc-error.patch George Dunlap
2012-06-08 11:57 ` George Dunlap
2012-06-08 11:54 ` [PATCH 4 of 4 RFC] imported patch pygrub-invalid-disk-catch.patch George Dunlap
2012-06-08 11:58 ` George Dunlap
2012-06-08 11:58 ` [PATCH 0 of 4 RFC] Populate-on-demand: Check pages being returned by the balloon driver George Dunlap
2012-06-14 10:14 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD9FCAF.4050002@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).