* [PATCH] qemu-traditional: disable msitranslate by default
@ 2012-06-27 13:39 Stefano Stabellini
2012-06-27 13:39 ` George Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Stabellini @ 2012-06-27 13:39 UTC (permalink / raw)
To: xen-devel; +Cc: george.dunlap, Ian Jackson
msitranslate is known to cause problems with some device drivers,
because it sets the real device in MSI mode while making the guest think
is actually in legacy interrupts mode. Some drivers are able to spot this
inconsistency and break (Nvidia drivers for example).
Disable the option by default.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff --git a/xenstore.c b/xenstore.c
index ac90366..8af280e 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -427,7 +427,7 @@ uint32_t xenstore_read_target(void)
return target_domid;
}
-#define PT_PCI_MSITRANSLATE_DEFAULT 1
+#define PT_PCI_MSITRANSLATE_DEFAULT 0
#define PT_PCI_POWER_MANAGEMENT_DEFAULT 0
int direct_pci_msitranslate;
int direct_pci_power_mgmt;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qemu-traditional: disable msitranslate by default
2012-06-27 13:39 [PATCH] qemu-traditional: disable msitranslate by default Stefano Stabellini
@ 2012-06-27 13:39 ` George Dunlap
2012-06-28 14:50 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: George Dunlap @ 2012-06-27 13:39 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel@lists.xensource.com, Ian Jackson
On 27/06/12 14:39, Stefano Stabellini wrote:
> msitranslate is known to cause problems with some device drivers,
> because it sets the real device in MSI mode while making the guest think
> is actually in legacy interrupts mode. Some drivers are able to spot this
> inconsistency and break (Nvidia drivers for example).
>
> Disable the option by default.
>
> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
This patch has been in XenServer for two releases now.
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qemu-traditional: disable msitranslate by default
2012-06-27 13:39 ` George Dunlap
@ 2012-06-28 14:50 ` Ian Jackson
0 siblings, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2012-06-28 14:50 UTC (permalink / raw)
To: George Dunlap; +Cc: xen-devel@lists.xensource.com, Stefano Stabellini
George Dunlap writes ("Re: [Xen-devel] [PATCH] qemu-traditional: disable msitranslate by default"):
> On 27/06/12 14:39, Stefano Stabellini wrote:
> > msitranslate is known to cause problems with some device drivers,
> > because it sets the real device in MSI mode while making the guest think
> > is actually in legacy interrupts mode. Some drivers are able to spot this
> > inconsistency and break (Nvidia drivers for example).
> >
> > Disable the option by default.
> >
> > Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> This patch has been in XenServer for two releases now.
>
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
Thanks.
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-28 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-27 13:39 [PATCH] qemu-traditional: disable msitranslate by default Stefano Stabellini
2012-06-27 13:39 ` George Dunlap
2012-06-28 14:50 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).