From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v6 07/13] libxl: convert libxl_device_nic_add to an async operation Date: Thu, 28 Jun 2012 14:30:07 +0100 Message-ID: <4FEC5C5F.2000304@citrix.com> References: <1339676475-33265-1-git-send-email-roger.pau@citrix.com> <1339676475-33265-8-git-send-email-roger.pau@citrix.com> <20452.22802.102071.107153@mariner.uk.xensource.com> <4FE9E091.2090001@citrix.com> <20457.61377.77775.31123@mariner.uk.xensource.com> <4FEC2983.5040500@citrix.com> <1340877416.10942.22.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340877416.10942.22.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > On Thu, 2012-06-28 at 10:53 +0100, Roger Pau Monne wrote: >> Ian Jackson wrote: >>> Roger Pau Monne writes ("Re: [PATCH v6 07/13] libxl: convert libxl_device_nic_add to an async operation"): >>>> Ian Jackson wrote: >>>>> Should we rename the functions libxl_*nic* or the structures *vif* ? >>>>> Or should we rename both, to "net" perhaps ? >>>> I think we should either rename the strucutres to nic also (because the >>>> also hold ioemu cards), or get rid of nic/vif an name everything net. >>> Can you try to rename everything to `net' and see if that turns out to >>> be an impenetrable yak ? >> I think it is much more easy to rename everything to nic, which provides >> the same level of abstraction from my PoV. Renaming everything to net >> it's a rather very big change. Would you be ok with that change? > > I'd be happy with nic, I think it fits better with libxl_device_disk > anyway. (if it were libxl_device_net would be more analogous to > libxl_device_storage or something) Done, I've added a pre-patch to rename every *vif* to nic.