From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v8 00/15] execute hotplug scripts from libxl
Date: Tue, 10 Jul 2012 12:31:32 +0100 [thread overview]
Message-ID: <4FFC1294.9040408@citrix.com> (raw)
In-Reply-To: <1341772363.797.2.camel@hastur.hellion.org.uk>
Ian Campbell wrote:
> (resending as I don't think I had SMTP setup properly on my laptop -- sorry if you get this twice!)
>
> On Wed, 2012-07-04 at 07:59 -0400, Roger Pau Monne wrote:
>> This new serie (v8) fixes a code refactoring problem that was present
>> in v7 (06/15 changed code introduced by 05/15).
>
> From somewhere in here I'm seeing timeouts waiting for the b/e to go to
> state 5 when doing cd-insert on an HVM guest. I suspect because this is
> (or should be) turned into a virtual media change rather than an actual
> device remove and insert?
>
> BTW libxl_cdrom_insert hasn't been async'd up yet -- I was actually just
> looking into that when I noticed this.
>
> Ian.
>
> ~# xl -vvv cd-insert dHVM-1 hdc /scratch/mini.iso,raw
> libxl: debug: libxl.c:3074:libxl_device_disk_remove: ao 0x8069c30: create: how=(nil) callback=(nil) poller=0x8069a50
> libxl: debug: libxl_event.c:512:libxl__ev_xswatch_register: watch w=0x8069dcc wpath=/local/domain/0/backend/qdisk/43/5632/state token=3/0: register slotnum=3
> libxl: debug: libxl.c:3074:libxl_device_disk_remove: ao 0x8069c30: inprogress: poller=0x8069a50, flags=i
> libxl: debug: libxl_event.c:457:watchfd_callback: watch w=0x8069dcc wpath=/local/domain/0/backend/qdisk/43/5632/state token=3/0: event epath=/local/domain/0/backend/qdisk/43/5632/state
> libxl: debug: libxl_event.c:600:devstate_watch_callback: backend /local/domain/0/backend/qdisk/43/5632/state wanted state 6 still waiting state 5
>
> [... long wait ...]
>
> libxl: debug: libxl_event.c:614:devstate_timeout: backend /local/domain/0/backend/qdisk/43/5632/state wanted state 6 timed out
> libxl: debug: libxl_event.c:549:libxl__ev_xswatch_deregister: watch w=0x8069dcc wpath=/local/domain/0/backend/qdisk/43/5632/state token=3/0: deregister slotnum=3
> libxl: debug: libxl_event.c:561:libxl__ev_xswatch_deregister: watch w=0x8069dcc: deregister unregistered
> libxl: debug: libxl_event.c:512:libxl__ev_xswatch_register: watch w=0x8069dcc wpath=/local/domain/0/backend/qdisk/43/5632/state token=3/1: register slotnum=3
> libxl: debug: libxl_event.c:457:watchfd_callback: watch w=0x8069dcc wpath=/local/domain/0/backend/qdisk/43/5632/state token=3/1: event epath=/local/domain/0/backend/qdisk/43/5632/state
> libxl: debug: libxl_event.c:600:devstate_watch_callback: backend /local/domain/0/backend/qdisk/43/5632/state wanted state 6 still waiting state 5
>
> [... long wait ...]
>
> libxl: debug: libxl_event.c:614:devstate_timeout: backend /local/domain/0/backend/qdisk/43/5632/state wanted state 6 timed out
> libxl: debug: libxl_event.c:549:libxl__ev_xswatch_deregister: watch w=0x8069dcc wpath=/local/domain/0/backend/qdisk/43/5632/state token=3/1: deregister slotnum=3
> libxl: debug: libxl_event.c:561:libxl__ev_xswatch_deregister: watch w=0x8069dcc: deregister unregistered
> libxl: debug: libxl_device.c:759:device_backend_callback: unable to disconnect device with path /local/domain/0/backend/qdisk/43/5632
> libxl: debug: libxl_event.c:1434:libxl__ao_complete: ao 0x8069c30: complete, rc=0
> libxl: debug: libxl_event.c:1406:libxl__ao__destroy: ao 0x8069c30: destroy
> libxl: debug: libxl.c:1958:libxl_device_disk_add: ao 0x8069c30: create: how=(nil) callback=(nil) poller=0x8069a50
> libxl: debug: libxl_device.c:255:libxl__device_disk_set_backend: Disk vdev=hdc spec.backend=unknown
> libxl: debug: libxl_device.c:258:libxl__device_disk_set_backend: format=raw cdrom=yes
> libxl: debug: libxl_device.c:209:disk_try_backend: Disk vdev=hdc, backend phy unsuitable as phys path not a block device
> libxl: debug: libxl_device.c:216:disk_try_backend: Disk vdev=hdc, backend tap unsuitable because blktap not available
> libxl: debug: libxl_device.c:293:libxl__device_disk_set_backend: Disk vdev=hdc, using backend qdisk
> libxl: debug: libxl_event.c:1434:libxl__ao_complete: ao 0x8069c30: complete, rc=0
> libxl: debug: libxl.c:1971:libxl_device_disk_add: ao 0x8069c30: inprogress: poller=0x8069a50, flags=ic
> libxl: debug: libxl_event.c:1406:libxl__ao__destroy: ao 0x8069c30: destroy
> xc: debug: hypercall buffer: total allocations:2 total releases:2
> xc: debug: hypercall buffer: current allocations:0 maximum allocations:2
> xc: debug: hypercall buffer: cache current size:1
> xc: debug: hypercall buffer: cache hits:0 misses:1 toobig:1
Yes, this is due to the fact that Qemu (traditional at least) doesn't
honour the connection/disconnection protocol, so neither removing the
frontend or setting the backend to "closing" (5), will make Qemu
disconnect the device. I used to have a special "dev->backend_type ==
QDISK" to skip the waiting, I've added it to my series again, and it
should solve the waiting problem.
next prev parent reply other threads:[~2012-07-10 11:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 11:59 [PATCH v8 00/15] execute hotplug scripts from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 01/15] libxl: change ao_device_remove to ao_device Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 02/15] libxl: move device model creation prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 03/15] libxl: convert libxl_domain_destroy to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 04/15] libxl: move bootloader data strucutres and prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 05/15] libxl: refactor disk addition to take a helper Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 06/15] libxl: convert libxl__device_disk_local_attach to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 07/15] libxl: rename vifs to nics Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 08/15] libxl: convert libxl_device_disk_add to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 09/15] libxl: convert libxl_device_nic_add to an async operation Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 10/15] libxl: add option to choose who executes hotplug scripts Roger Pau Monne
2012-07-06 10:28 ` Ian Campbell
2012-07-10 9:20 ` Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 11/15] libxl: rename _IOEMU nic type to VIF_IOEMU Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 12/15] libxl: set correct nic type depending on the guest Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 13/15] libxl: use libxl__xs_path_cleanup on device_destroy Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 14/15] libxl: call hotplug scripts for disk devices from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 15/15] libxl: call hotplug scripts for nic " Roger Pau Monne
2012-07-08 18:32 ` [PATCH v8 00/15] execute hotplug scripts " Ian Campbell
2012-07-08 18:41 ` Ian Campbell
2012-07-10 11:31 ` Roger Pau Monne [this message]
2012-07-10 15:55 ` Ian Campbell
2012-07-10 16:07 ` Roger Pau Monne
2012-07-10 16:57 ` Ian Campbell
2012-07-10 17:23 ` Roger Pau Monne
2012-07-10 17:30 ` Ian Campbell
2012-07-10 17:39 ` Roger Pau Monne
2012-07-10 17:40 ` Ian Campbell
2012-07-11 9:08 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC1294.9040408@citrix.com \
--to=roger.pau@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).