From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v8 00/15] execute hotplug scripts from libxl
Date: Tue, 10 Jul 2012 17:07:21 +0100 [thread overview]
Message-ID: <4FFC5339.4060504@citrix.com> (raw)
In-Reply-To: <1341935753.8586.48.camel@hastur.hellion.org.uk>
Ian Campbell wrote:
> On Tue, 2012-07-10 at 07:31 -0400, Roger Pau Monne wrote:
>> Ian Campbell wrote:
>>> (resending as I don't think I had SMTP setup properly on my laptop -- sorry if you get this twice!)
>>>
>>> On Wed, 2012-07-04 at 07:59 -0400, Roger Pau Monne wrote:
>>>> This new serie (v8) fixes a code refactoring problem that was present
>>>> in v7 (06/15 changed code introduced by 05/15).
>>> From somewhere in here I'm seeing timeouts waiting for the b/e to go to
>>> state 5 when doing cd-insert on an HVM guest. I suspect because this is
>>> (or should be) turned into a virtual media change rather than an actual
>>> device remove and insert?
>>>
>>> BTW libxl_cdrom_insert hasn't been async'd up yet -- I was actually just
>>> looking into that when I noticed this.
>>>
> [...]
>> Yes, this is due to the fact that Qemu (traditional at least) doesn't
>> honour the connection/disconnection protocol, so neither removing the
>> frontend or setting the backend to "closing" (5), will make Qemu
>> disconnect the device. I used to have a special "dev->backend_type ==
>> QDISK" to skip the waiting, I've added it to my series again, and it
>> should solve the waiting problem.
>
> Actually I think libxl_cdrom_insert is just broken. For an HVM guest
> with an emulated CDROM (i..e the normal case, even if you have PV
> drivers) then the media change protocol is not to remove the device and
> reinsert it. Instead you are supposed to just change the params key. I
> have half a patch to do this (as part of the asyncification of the
> interface) and I think it will make this special case unnecessary, at
> least or the cdrom case.
>
> Perhaps you also need it for the disk case though, I don't know. Or
> maybe qemu should be taught to honour the protocol?
I'm working on making vfb/vkb async, once that is done I can take a look
on this, but since the device removal is done after Qemu has been killed
I don't have much expectations that this is going to work (at least for
the shutdown/destroy case).
The block-attach/detach case might work with this approach.
next prev parent reply other threads:[~2012-07-10 16:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 11:59 [PATCH v8 00/15] execute hotplug scripts from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 01/15] libxl: change ao_device_remove to ao_device Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 02/15] libxl: move device model creation prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 03/15] libxl: convert libxl_domain_destroy to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 04/15] libxl: move bootloader data strucutres and prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 05/15] libxl: refactor disk addition to take a helper Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 06/15] libxl: convert libxl__device_disk_local_attach to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 07/15] libxl: rename vifs to nics Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 08/15] libxl: convert libxl_device_disk_add to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 09/15] libxl: convert libxl_device_nic_add to an async operation Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 10/15] libxl: add option to choose who executes hotplug scripts Roger Pau Monne
2012-07-06 10:28 ` Ian Campbell
2012-07-10 9:20 ` Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 11/15] libxl: rename _IOEMU nic type to VIF_IOEMU Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 12/15] libxl: set correct nic type depending on the guest Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 13/15] libxl: use libxl__xs_path_cleanup on device_destroy Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 14/15] libxl: call hotplug scripts for disk devices from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 15/15] libxl: call hotplug scripts for nic " Roger Pau Monne
2012-07-08 18:32 ` [PATCH v8 00/15] execute hotplug scripts " Ian Campbell
2012-07-08 18:41 ` Ian Campbell
2012-07-10 11:31 ` Roger Pau Monne
2012-07-10 15:55 ` Ian Campbell
2012-07-10 16:07 ` Roger Pau Monne [this message]
2012-07-10 16:57 ` Ian Campbell
2012-07-10 17:23 ` Roger Pau Monne
2012-07-10 17:30 ` Ian Campbell
2012-07-10 17:39 ` Roger Pau Monne
2012-07-10 17:40 ` Ian Campbell
2012-07-11 9:08 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC5339.4060504@citrix.com \
--to=roger.pau@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).