From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v8 00/15] execute hotplug scripts from libxl
Date: Wed, 11 Jul 2012 10:08:05 +0100 [thread overview]
Message-ID: <4FFD4275.1080403@citrix.com> (raw)
In-Reply-To: <1341942024.8586.97.camel@hastur.hellion.org.uk>
Ian Campbell wrote:
> On Tue, 2012-07-10 at 13:23 -0400, Roger Pau Monne wrote:
>>>> I'm working on making vfb/vkb async, once that is done I can take a look
>>>> on this,
>>> Cool. BTW is the other stuff ready? I guess it is waiting on IanJ to
>>> review again?
>> I've changed the series according to your comments, and I'm waiting for
>> IanJ review.
>
> BTW, an interesting enhancement might be to read
> the /local/domain/0/backend/vif/23/0/hotplug-error node and print it
> out. Currently with the "hotplug: vif: fail if a duplicate vifname is
> used" patch that I've just posted xl continues on despite the failure.
> With this series this is improved to:
> # xl cr /etc/xen//debian-x86_32p-1
> Parsing config from /etc/xen//debian-x86_32p-1
> libxl: warning: libxl_exec.c:118:libxl_report_child_exitstatus: /etc/xen/scripts/vif-bridge online [11939] exited with error status 1
>
> but with xm I get:
> # xm cr /etc//xen/debian-HVM-1
> Using config file "/etc//xen/debian-HVM-1".
> Error: Device 0 (vif) could not be connected. Cannot rename interface vif20.0. An interface with name foo already exists.
>
> which is much friendlier.
Ok, so on error I will read "hotplug-error" and add it to the error
message. I think this is a Linux only thing, but it won't hurt to add it.
>
> Also it seems that despite xl reporting the error with you patches the
> domain is still running, although without networking... If a hotplug
> script fails can we abort and destroy the partially constructed domain
> instead?
Yes, I will change that and print and error and exit instead of just
printing a warning.
Thanks for the report.
prev parent reply other threads:[~2012-07-11 9:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 11:59 [PATCH v8 00/15] execute hotplug scripts from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 01/15] libxl: change ao_device_remove to ao_device Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 02/15] libxl: move device model creation prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 03/15] libxl: convert libxl_domain_destroy to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 04/15] libxl: move bootloader data strucutres and prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 05/15] libxl: refactor disk addition to take a helper Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 06/15] libxl: convert libxl__device_disk_local_attach to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 07/15] libxl: rename vifs to nics Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 08/15] libxl: convert libxl_device_disk_add to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 09/15] libxl: convert libxl_device_nic_add to an async operation Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 10/15] libxl: add option to choose who executes hotplug scripts Roger Pau Monne
2012-07-06 10:28 ` Ian Campbell
2012-07-10 9:20 ` Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 11/15] libxl: rename _IOEMU nic type to VIF_IOEMU Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 12/15] libxl: set correct nic type depending on the guest Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 13/15] libxl: use libxl__xs_path_cleanup on device_destroy Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 14/15] libxl: call hotplug scripts for disk devices from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 15/15] libxl: call hotplug scripts for nic " Roger Pau Monne
2012-07-08 18:32 ` [PATCH v8 00/15] execute hotplug scripts " Ian Campbell
2012-07-08 18:41 ` Ian Campbell
2012-07-10 11:31 ` Roger Pau Monne
2012-07-10 15:55 ` Ian Campbell
2012-07-10 16:07 ` Roger Pau Monne
2012-07-10 16:57 ` Ian Campbell
2012-07-10 17:23 ` Roger Pau Monne
2012-07-10 17:30 ` Ian Campbell
2012-07-10 17:39 ` Roger Pau Monne
2012-07-10 17:40 ` Ian Campbell
2012-07-11 9:08 ` Roger Pau Monne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD4275.1080403@citrix.com \
--to=roger.pau@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).