From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v2 1/4] xen: move physmap saving into a separate function Date: Tue, 4 Jul 2017 16:05:50 +0000 Message-ID: <4b1c13c385fd4427a112b92bd6ec203e@AMSPEX02CL01.citrite.net> References: <1499183267-28623-1-git-send-email-igor.druzhinin@citrix.com> <1499183267-28623-2-git-send-email-igor.druzhinin@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSQKm-0005gq-9H for xen-devel@lists.xenproject.org; Tue, 04 Jul 2017 16:05:52 +0000 In-Reply-To: <1499183267-28623-2-git-send-email-igor.druzhinin@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Igor Druzhinin , "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" Cc: Anthony Perard , "pbonzini@redhat.com" , "sstabellini@kernel.org" List-Id: xen-devel@lists.xenproject.org Cgo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gRnJvbTogSWdvciBEcnV6aGluaW4KPiBT ZW50OiAwNCBKdWx5IDIwMTcgMTY6NDgKPiBUbzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnOyBxZW11LWRldmVsQG5vbmdudS5vcmcKPiBDYzogSWdvciBEcnV6aGluaW4gPGlnb3IuZHJ1 emhpbmluQGNpdHJpeC5jb20+OyBzc3RhYmVsbGluaUBrZXJuZWwub3JnOwo+IEFudGhvbnkgUGVy YXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPjsgUGF1bCBEdXJyYW50Cj4gPFBhdWwuRHVy cmFudEBjaXRyaXguY29tPjsgcGJvbnppbmlAcmVkaGF0LmNvbQo+IFN1YmplY3Q6IFtQQVRDSCB2 MiAxLzRdIHhlbjogbW92ZSBwaHlzbWFwIHNhdmluZyBpbnRvIGEgc2VwYXJhdGUgZnVuY3Rpb24K PiAKPiBOb24tZnVuY3Rpb25hbCBjaGFuZ2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWdvciBEcnV6 aGluaW4gPGlnb3IuZHJ1emhpbmluQGNpdHJpeC5jb20+CgpSZXZpZXdlZC1ieTogUGF1bCBEdXJy YW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KCj4gLS0tCj4gIGh3L2kzODYveGVuL3hlbi1o dm0uYyB8IDU3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAtLS0t LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2h3L2kzODYveGVuL3hlbi1odm0uYyBiL2h3L2kzODYveGVu L3hlbi1odm0uYwo+IGluZGV4IGNmZmE3ZTIuLmQyNTljZjcgMTAwNjQ0Cj4gLS0tIGEvaHcvaTM4 Ni94ZW4veGVuLWh2bS5jCj4gKysrIGIvaHcvaTM4Ni94ZW4veGVuLWh2bS5jCj4gQEAgLTMwNSw2 ICszMDUsMzYgQEAgc3RhdGljIGh3YWRkciB4ZW5fcGh5c19vZmZzZXRfdG9fZ2FkZHIoaHdhZGRy Cj4gc3RhcnRfYWRkciwKPiAgICAgIHJldHVybiBzdGFydF9hZGRyOwo+ICB9Cj4gCj4gK3N0YXRp YyBpbnQgeGVuX3NhdmVfcGh5c21hcChYZW5JT1N0YXRlICpzdGF0ZSwgWGVuUGh5c21hcCAqcGh5 c21hcCkKPiArewo+ICsgICAgY2hhciBwYXRoWzgwXSwgdmFsdWVbMTddOwo+ICsKPiArICAgIHNu cHJpbnRmKHBhdGgsIHNpemVvZihwYXRoKSwKPiArICAgICAgICAgICAgIi9sb2NhbC9kb21haW4v MC9kZXZpY2UtCj4gbW9kZWwvJWQvcGh5c21hcC8lIlBSSXg2NCIvc3RhcnRfYWRkciIsCj4gKyAg ICAgICAgICAgIHhlbl9kb21pZCwgKHVpbnQ2NF90KXBoeXNtYXAtPnBoeXNfb2Zmc2V0KTsKPiAr ICAgIHNucHJpbnRmKHZhbHVlLCBzaXplb2YodmFsdWUpLCAiJSJQUkl4NjQsICh1aW50NjRfdClw aHlzbWFwLQo+ID5zdGFydF9hZGRyKTsKPiArICAgIGlmICgheHNfd3JpdGUoc3RhdGUtPnhlbnN0 b3JlLCAwLCBwYXRoLCB2YWx1ZSwgc3RybGVuKHZhbHVlKSkpIHsKPiArICAgICAgICByZXR1cm4g LTE7Cj4gKyAgICB9Cj4gKyAgICBzbnByaW50ZihwYXRoLCBzaXplb2YocGF0aCksCj4gKyAgICAg ICAgICAgICIvbG9jYWwvZG9tYWluLzAvZGV2aWNlLW1vZGVsLyVkL3BoeXNtYXAvJSJQUkl4NjQi L3NpemUiLAo+ICsgICAgICAgICAgICB4ZW5fZG9taWQsICh1aW50NjRfdClwaHlzbWFwLT5waHlz X29mZnNldCk7Cj4gKyAgICBzbnByaW50Zih2YWx1ZSwgc2l6ZW9mKHZhbHVlKSwgIiUiUFJJeDY0 LCAodWludDY0X3QpcGh5c21hcC0+c2l6ZSk7Cj4gKyAgICBpZiAoIXhzX3dyaXRlKHN0YXRlLT54 ZW5zdG9yZSwgMCwgcGF0aCwgdmFsdWUsIHN0cmxlbih2YWx1ZSkpKSB7Cj4gKyAgICAgICAgcmV0 dXJuIC0xOwo+ICsgICAgfQo+ICsgICAgaWYgKHBoeXNtYXAtPm5hbWUpIHsKPiArICAgICAgICBz bnByaW50ZihwYXRoLCBzaXplb2YocGF0aCksCj4gKyAgICAgICAgICAgICAgICAiL2xvY2FsL2Rv bWFpbi8wL2RldmljZS1tb2RlbC8lZC9waHlzbWFwLyUiUFJJeDY0Ii9uYW1lIiwKPiArICAgICAg ICAgICAgICAgIHhlbl9kb21pZCwgKHVpbnQ2NF90KXBoeXNtYXAtPnBoeXNfb2Zmc2V0KTsKPiAr ICAgICAgICBpZiAoIXhzX3dyaXRlKHN0YXRlLT54ZW5zdG9yZSwgMCwgcGF0aCwKPiArICAgICAg ICAgICAgICAgICAgICAgIHBoeXNtYXAtPm5hbWUsIHN0cmxlbihwaHlzbWFwLT5uYW1lKSkpIHsK PiArICAgICAgICAgICAgcmV0dXJuIC0xOwo+ICsgICAgICAgIH0KPiArICAgIH0KPiArICAgIHJl dHVybiAwOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHhlbl9hZGRfdG9fcGh5c21hcChYZW5JT1N0 YXRlICpzdGF0ZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaHdhZGRyIHN0YXJ0 X2FkZHIsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJhbV9hZGRyX3Qgc2l6ZSwK PiBAQCAtMzE2LDcgKzM0Niw2IEBAIHN0YXRpYyBpbnQgeGVuX2FkZF90b19waHlzbWFwKFhlbklP U3RhdGUgKnN0YXRlLAo+ICAgICAgWGVuUGh5c21hcCAqcGh5c21hcCA9IE5VTEw7Cj4gICAgICBo d2FkZHIgcGZuLCBzdGFydF9ncGZuOwo+ICAgICAgaHdhZGRyIHBoeXNfb2Zmc2V0ID0gbWVtb3J5 X3JlZ2lvbl9nZXRfcmFtX2FkZHIobXIpOwo+IC0gICAgY2hhciBwYXRoWzgwXSwgdmFsdWVbMTdd Owo+ICAgICAgY29uc3QgY2hhciAqbXJfbmFtZTsKPiAKPiAgICAgIGlmIChnZXRfcGh5c21hcHBp bmcoc3RhdGUsIHN0YXJ0X2FkZHIsIHNpemUpKSB7Cj4gQEAgLTM2OCwzMSArMzk3LDcgQEAgZ29f cGh5c21hcDoKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGFydF9hZGRy ID4+IFRBUkdFVF9QQUdFX0JJVFMsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKHN0YXJ0X2FkZHIgKyBzaXplIC0gMSkgPj4gVEFSR0VUX1BBR0VfQklUUywKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRU5fRE9NQ1RMX01FTV9DQUNIRUFUVFJfV0Ip Owo+IC0KPiAtICAgIHNucHJpbnRmKHBhdGgsIHNpemVvZihwYXRoKSwKPiAtICAgICAgICAgICAg Ii9sb2NhbC9kb21haW4vMC9kZXZpY2UtCj4gbW9kZWwvJWQvcGh5c21hcC8lIlBSSXg2NCIvc3Rh cnRfYWRkciIsCj4gLSAgICAgICAgICAgIHhlbl9kb21pZCwgKHVpbnQ2NF90KXBoeXNfb2Zmc2V0 KTsKPiAtICAgIHNucHJpbnRmKHZhbHVlLCBzaXplb2YodmFsdWUpLCAiJSJQUkl4NjQsICh1aW50 NjRfdClzdGFydF9hZGRyKTsKPiAtICAgIGlmICgheHNfd3JpdGUoc3RhdGUtPnhlbnN0b3JlLCAw LCBwYXRoLCB2YWx1ZSwgc3RybGVuKHZhbHVlKSkpIHsKPiAtICAgICAgICByZXR1cm4gLTE7Cj4g LSAgICB9Cj4gLSAgICBzbnByaW50ZihwYXRoLCBzaXplb2YocGF0aCksCj4gLSAgICAgICAgICAg ICIvbG9jYWwvZG9tYWluLzAvZGV2aWNlLW1vZGVsLyVkL3BoeXNtYXAvJSJQUkl4NjQiL3NpemUi LAo+IC0gICAgICAgICAgICB4ZW5fZG9taWQsICh1aW50NjRfdClwaHlzX29mZnNldCk7Cj4gLSAg ICBzbnByaW50Zih2YWx1ZSwgc2l6ZW9mKHZhbHVlKSwgIiUiUFJJeDY0LCAodWludDY0X3Qpc2l6 ZSk7Cj4gLSAgICBpZiAoIXhzX3dyaXRlKHN0YXRlLT54ZW5zdG9yZSwgMCwgcGF0aCwgdmFsdWUs IHN0cmxlbih2YWx1ZSkpKSB7Cj4gLSAgICAgICAgcmV0dXJuIC0xOwo+IC0gICAgfQo+IC0gICAg aWYgKG1yX25hbWUpIHsKPiAtICAgICAgICBzbnByaW50ZihwYXRoLCBzaXplb2YocGF0aCksCj4g LSAgICAgICAgICAgICAgICAiL2xvY2FsL2RvbWFpbi8wL2RldmljZS1tb2RlbC8lZC9waHlzbWFw LyUiUFJJeDY0Ii9uYW1lIiwKPiAtICAgICAgICAgICAgICAgIHhlbl9kb21pZCwgKHVpbnQ2NF90 KXBoeXNfb2Zmc2V0KTsKPiAtICAgICAgICBpZiAoIXhzX3dyaXRlKHN0YXRlLT54ZW5zdG9yZSwg MCwgcGF0aCwgbXJfbmFtZSwgc3RybGVuKG1yX25hbWUpKSkgewo+IC0gICAgICAgICAgICByZXR1 cm4gLTE7Cj4gLSAgICAgICAgfQo+IC0gICAgfQo+IC0KPiAtICAgIHJldHVybiAwOwo+ICsgICAg cmV0dXJuIHhlbl9zYXZlX3BoeXNtYXAoc3RhdGUsIHBoeXNtYXApOwo+ICB9Cj4gCj4gIHN0YXRp YyBpbnQgeGVuX3JlbW92ZV9mcm9tX3BoeXNtYXAoWGVuSU9TdGF0ZSAqc3RhdGUsCj4gLS0KPiAy LjcuNAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhl bi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0 cy54ZW4ub3JnL3hlbi1kZXZlbAo=