From: Julien Grall <julien.grall@arm.com>
To: vijay.kilari@gmail.com, xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com,
Vijaya Kumar K <Vijaya.Kumar@cavium.com>
Subject: Re: [PATCH v2] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP
Date: Tue, 14 Mar 2017 15:32:10 +0000 [thread overview]
Message-ID: <4c994ce5-680f-4aa7-3e3e-bd72e89c9f69@arm.com> (raw)
In-Reply-To: <1489405390-20087-1-git-send-email-vijay.kilari@gmail.com>
Hello Vijay,
On 13/03/17 11:43, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@cavium.com>
>
> On ARM, virt_to_mfn uses the hardware for address
> translation. So if the virtual address is not mapped translation
> fault is raised.On ARM, DIRECTMAP_VIRT region is direct mapped.
This is not true. As I said before, all the memory will be direct mapped
on ARM64 but not on ARM32.
For ARM32, only xenheap will be direct mapped. So you may want to return
is_xenheap_mfn(...). Or even return false in all the case. Either is
fine by me, but it would need to be explained in the code.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-14 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 11:43 [PATCH v2] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP vijay.kilari
2017-03-13 13:42 ` Jan Beulich
2017-03-14 4:57 ` Vijay Kilari
2017-03-14 15:32 ` Julien Grall [this message]
2017-03-15 5:11 ` Vijay Kilari
2017-03-24 10:54 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c994ce5-680f-4aa7-3e3e-bd72e89c9f69@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).