Re: [PATCH v3 10/18] x86emul: test coverage for SSE/SSE2 insns

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 15/02/17 11:13, Jan Beulich wrote:
> --- a/tools/tests/x86_emulator/Makefile
> +++ b/tools/tests/x86_emulator/Makefile
> @@ -11,11 +11,36 @@ all: $(TARGET)
>  run: $(TARGET)
>  	./$(TARGET)
>  
> -TESTCASES := blowfish
> +TESTCASES := blowfish simd
>  
>  blowfish-cflags := ""
>  blowfish-cflags-x86_32 := "-mno-accumulate-outgoing-args -Dstatic="
>  
> +sse-vecs := 16
> +sse-ints :=
> +sse-flts := 4
> +sse2-vecs := $(sse-vecs)
> +sse2-ints := 1 2 4 8
> +sse2-flts := 4 8
> +
> +# When converting SSE to AVX, have the compiler avoid XMM0 to widen
> +# coverage og the VEX.vvvv checks in the emulator.

coverage of.

> @@ -2589,6 +2665,9 @@ int main(int argc, char **argv)
>              continue;
>          }
>  
> +        if ( blobs[j].check_cpu && !blobs[j].check_cpu() )
> +            continue;

Worth printing that we skip the blob?

Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>  (I
haven't looked at the internals of the simd blob in detail.)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel