From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH] hvmloader: avoid tests when they would clobber used memory
Date: Thu, 18 May 2017 11:19:39 +0100 [thread overview]
Message-ID: <4e5df78f-71b4-fdf1-f1a0-204e33180cba@citrix.com> (raw)
In-Reply-To: <591AEDB9020000780015A173@prv-mh.provo.novell.com>
On 16/05/17 11:16, Jan Beulich wrote:
> First of all limit the memory range used for testing to 4Mb: There's no
> point placing page tables right above 8Mb when they can equally well
> live at the bottom of the chunk at 4Mb - rep_io_test() cares about the
> 5Mb...7Mb range only anyway. In a subsequent patch this will then also
> allow simply looking for an unused 4Mb range (instead of using a build
> time determined one).
>
> Extend the "skip tests" condition beyond the "is there enough memory"
> question.
>
> Reported-by: Charles Arnold <carnold@suse.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Gary Lin <glin@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
As already identified, I'm not convinced that these tests should stay,
but for older releases, they shouldn't exhibit this failure mode.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-18 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 10:16 [PATCH] hvmloader: avoid tests when they would clobber used memory Jan Beulich
2017-05-18 10:19 ` Andrew Cooper [this message]
2017-05-19 13:46 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e5df78f-71b4-fdf1-f1a0-204e33180cba@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).