From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 4 of 9] libxl: ensure result of libxl_poolid_to_name is always dynamically allocated
Date: Fri, 13 Aug 2010 14:50:07 +0100 [thread overview]
Message-ID: <4fa4efb9c63e1ef60daa.1281707407@localhost.localdomain> (raw)
In-Reply-To: <patchbomb.1281707403@localhost.localdomain>
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1281706573 -3600
# Node ID 4fa4efb9c63e1ef60daae928b0d7c5ca992681dd
# Parent 06e63fc8240a8d5902087947e016b7f69ab53071
libxl: ensure result of libxl_poolid_to_name is always dynamically allocated
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 06e63fc8240a -r 4fa4efb9c63e tools/libxl/libxl_utils.c
--- a/tools/libxl/libxl_utils.c Fri Aug 13 14:36:13 2010 +0100
+++ b/tools/libxl/libxl_utils.c Fri Aug 13 14:36:13 2010 +0100
@@ -97,7 +97,7 @@ char *libxl_poolid_to_name(libxl_ctx *ct
char *s;
if (poolid == 0)
- return "Pool-0";
+ return strdup("Pool-0");
snprintf(path, sizeof(path), "/local/pool/%d/name", poolid);
s = xs_read(ctx->xsh, XBT_NULL, path, &len);
return s;
next prev parent reply other threads:[~2010-08-13 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 13:50 [PATCH 0 of 9] libxl: autogenerate type definitions and destructor functions Ian Campbell
2010-08-13 13:50 ` [PATCH 1 of 9] xl: use the regular implicit rules to build the xl .o files Ian Campbell
2010-08-13 13:50 ` [PATCH 2 of 9] libxl: define specific types for string list and key, value list Ian Campbell
2010-08-13 13:50 ` [PATCH 3 of 9] libxl: move various enum and #defines above datastructure definitions Ian Campbell
2010-08-13 13:50 ` Ian Campbell [this message]
2010-08-13 13:50 ` [PATCH 5 of 9] libxl: move type definitions into _libxl_types.h Ian Campbell
2010-08-13 13:50 ` [PATCH 6 of 9] libxl: tweak formatting/whitespace of _libxl_types.h Ian Campbell
2010-08-13 13:50 ` [PATCH 7 of 9] libxl: autogenerate _libxl_types.h Ian Campbell
2010-08-13 13:50 ` [PATCH 8 of 9] libxl: generate destructors for each libxl defined type Ian Campbell
2010-08-13 13:50 ` [PATCH 9 of 9] xl: free the libxl types contained in struct domain_config Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fa4efb9c63e1ef60daa.1281707407@localhost.localdomain \
--to=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).