From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/9] tools/build: fix pygrub linking
Date: Tue, 17 Jul 2012 17:34:41 +0100 [thread overview]
Message-ID: <50059421.406@citrix.com> (raw)
In-Reply-To: <20485.37211.873318.627523@mariner.uk.xensource.com>
Ian Jackson wrote:
> Roger Pau Monne writes ("Re: [PATCH 2/9] tools/build: fix pygrub linking"):
>> diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
>> index bd22dd4..182afdd 100644
>> --- a/tools/pygrub/Makefile
>> +++ b/tools/pygrub/Makefile
>> @@ -14,7 +14,9 @@ install: all
>> $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \
>> --install-scripts=$(PRIVATE_BINDIR) --force
>> $(INSTALL_DIR) $(DESTDIR)/var/run/xend/boot
>> +ifneq ($(shell readlink -f $(DESTDIR)/$(BINDIR)), $(shell readlink -f
>> $(PRIVATE_BINDIR)))
>> ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR)
>> +endif
>
> Why are we doing all this work in make with $(shell...) rather than
> simply in the command stanza ?
>
> Also I'm a bit confused. This problem occurs only when DESTDIR="" ?
No, this occurs when $(BINDIR) == $(PRIVATE_BINDIR), but we cannot use
the "test -e", because we might have previous versions of pygrub
installed which should also be overwritten by the link, or the user will
keep using the old version.
> In which case perhaps the right answer is something like
> set -e; if ! test -e $(DESTDIR)/$(BINDIR)/pygrub; then \
> ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \
> fi
>
> Ian.
next prev parent reply other threads:[~2012-07-17 16:34 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 10:23 [PATCH 0/9] NetBSD: minor fixes and hotplug execution Roger Pau Monne
2012-07-11 10:23 ` [PATCH 1/9] xenstore: don't print an error when gntdev cannot be opened Roger Pau Monne
2012-07-23 11:42 ` Ian Campbell
2012-07-11 10:23 ` [PATCH 2/9] tools/build: fix pygrub linking Roger Pau Monne
2012-07-11 11:00 ` Christoph Egger
2012-07-12 16:30 ` Roger Pau Monne
2012-07-17 16:22 ` Ian Jackson
2012-07-17 16:34 ` Roger Pau Monne [this message]
2012-07-17 18:17 ` Ian Jackson
2012-07-18 8:26 ` Roger Pau Monne
2012-07-18 10:48 ` Ian Jackson
2012-07-18 13:55 ` Roger Pau Monne
2012-07-19 14:48 ` Ian Jackson
2012-07-19 15:00 ` Roger Pau Monne
2012-07-19 15:03 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 3/9] pygrub: don't leave fds open Roger Pau Monne
2012-07-11 11:02 ` Christoph Egger
2012-07-17 16:01 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 4/9] build: include Tools.mk first in tools/Rules.mk Roger Pau Monne
2012-07-11 11:52 ` Christoph Egger
2012-07-23 11:34 ` Ian Campbell
2012-07-23 12:19 ` Christoph Egger
2012-07-25 9:32 ` Roger Pau Monne
2012-07-25 10:39 ` Ian Campbell
2012-07-25 10:56 ` Roger Pau Monne
2012-07-25 16:43 ` Ian Campbell
2012-07-11 10:23 ` [PATCH 5/9] libxl: react correctly to POLLHUP Roger Pau Monne
2012-07-17 16:01 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 6/9] libxl: check backend state before setting it to "closing" Roger Pau Monne
2012-07-17 16:05 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 7/9] hotplug/NetBSD: check type of file to attach from params Roger Pau Monne
2012-07-11 11:54 ` Christoph Egger
2012-07-17 16:06 ` Ian Jackson
2012-07-17 16:35 ` Roger Pau Monne
2012-07-11 10:23 ` [PATCH 8/9] libxl: call hotplug scripts from xl for NetBSD Roger Pau Monne
2012-07-17 16:07 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 9/9] init/NetBSD: move xenbackendd to xend init script Roger Pau Monne
2012-07-11 12:02 ` Christoph Egger
2012-07-17 16:08 ` Ian Jackson
2012-07-17 16:23 ` Roger Pau Monne
2012-07-18 9:04 ` Christoph Egger
2012-07-18 9:43 ` Roger Pau Monne
2012-07-18 9:46 ` Christoph Egger
2012-07-18 9:46 ` Roger Pau Monne
2012-07-18 10:50 ` Ian Jackson
2012-07-18 11:02 ` Roger Pau Monne
2012-07-18 9:02 ` Christoph Egger
2012-07-23 12:20 ` [PATCH 0/9] NetBSD: minor fixes and hotplug execution Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50059421.406@citrix.com \
--to=roger.pau@citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).