From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v9 16/17] libxl: convert libxl_device_vkb_add to an async operation
Date: Thu, 19 Jul 2012 17:41:03 +0100 [thread overview]
Message-ID: <5008389F.4060401@citrix.com> (raw)
In-Reply-To: <20488.14185.962905.269760@mariner.uk.xensource.com>
Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v9 16/17] libxl: convert libxl_device_vkb_add to an async operation"):
>> Split libxl_device_vkb_add into libxl__device_vkb_add (to be used
>> inside already running ao's), and make libxl_device_vkb_add a stub to
>> call libxl__device_vkb_add.
> ...
>> - dcs->aodevs.size = d_config->num_disks;
>> + if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM) {
>> + assert(!d_config->vkbs && !d_config->num_vkbs);
>
> This is rather unfriendly - doesn't it amount to aborting on an
> invalid domain configuration. And I'm not sure I understand the
> logic, which is new in your patch.
This was part of the previous code, but this was done inside of a switch
instead of an if. Since it's not possible to specify vkb devices in the
config file (at least xl.cfg(5) doesn't mention anything about vkbs),
I'm quite sure d_config->vkbs == NULL and d_config->num_vkbs == 0 always
or something has gone extremely wrong, just added the abort to be sure.
next prev parent reply other threads:[~2012-07-19 16:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 9:44 [PATCH v9 00/15] execute hotplug scripts from libxl Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 01/17] libxl: change ao_device_remove to ao_device Roger Pau Monne
2012-07-18 16:29 ` Ian Jackson
2012-07-19 15:15 ` Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 02/17] libxl: move device model creation prototypes Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 03/17] libxl: convert libxl_domain_destroy to an async op Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 04/17] libxl: move bootloader data strucutres and prototypes Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 05/17] libxl: refactor disk addition to take a helper Roger Pau Monne
2012-07-17 16:46 ` Ian Jackson
2012-07-20 10:38 ` Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 06/17] libxl: convert libxl__device_disk_local_attach to an async op Roger Pau Monne
2012-07-19 16:16 ` Ian Jackson
2012-07-20 9:48 ` Roger Pau Monne
2012-07-20 11:27 ` Ian Jackson
2012-07-20 12:52 ` Roger Pau Monne
2012-07-20 17:45 ` Ian Jackson
2012-07-13 9:44 ` [PATCH v9 07/17] libxl: rename vifs to nics Roger Pau Monne
2012-07-19 15:12 ` Ian Jackson
2012-07-13 9:44 ` [PATCH v9 08/17] libxl: convert libxl_device_disk_add to an async op Roger Pau Monne
2012-07-19 15:58 ` Ian Jackson
2012-07-19 16:14 ` Roger Pau Monne
2012-07-20 10:43 ` Ian Jackson
2012-07-20 9:41 ` Ian Campbell
2012-07-20 10:54 ` Roger Pau Monne
2012-07-20 11:28 ` Ian Jackson
2012-07-13 9:44 ` [PATCH v9 09/17] libxl: convert libxl_device_nic_add to an async operation Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 10/17] libxl: add option to choose who executes hotplug scripts Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 11/17] libxl: rename _IOEMU nic type to VIF_IOEMU Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 12/17] libxl: set correct nic type depending on the guest Roger Pau Monne
2012-07-19 16:29 ` Ian Jackson
2012-07-13 9:44 ` [PATCH v9 13/17] libxl: use libxl__xs_path_cleanup on device_destroy Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 14/17] libxl: call hotplug scripts for disk devices from libxl Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 15/17] libxl: call hotplug scripts for nic " Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 16/17] libxl: convert libxl_device_vkb_add to an async operation Roger Pau Monne
2012-07-19 16:35 ` Ian Jackson
2012-07-19 16:41 ` Roger Pau Monne [this message]
2012-07-20 10:49 ` Ian Jackson
2012-07-20 11:00 ` Roger Pau Monne
2012-07-13 9:44 ` [PATCH v9 17/17] libxl: convert libxl_device_vfb_add " Roger Pau Monne
2012-07-26 10:42 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5008389F.4060401@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).