From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH 1 of 3 v5/leftover] libxl: enable automatic placement of guests on NUMA nodes Date: Fri, 20 Jul 2012 15:07:34 +0200 Message-ID: <50095816.40807@amd.com> References: <5fa66c8b9093399e5bc3.1342458792@Solace> <5007FBCE.6000201@amd.com> <1342707771.19530.235.camel@Solace> <1342772429.19530.247.camel@Solace> <5009161C.2060005@amd.com> <1342777496.19530.271.camel@Solace> <50094557.8020208@amd.com> <1342788890.19530.319.camel@Solace> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1342788890.19530.319.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Ian Campbell , Stefano Stabellini , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , xen-devel List-Id: xen-devel@lists.xenproject.org On 07/20/2012 02:54 PM, Dario Faggioli wrote: > On Fri, 2012-07-20 at 13:47 +0200, Andre Przywara wrote: >>> That would be nice. If you happen to have time to put something like >>> "3*nrdomains_diff+memfree_diff" and see how it goes, I'll be happy to >>> include at least that change, even in next posting. >> >> I did that. Guests are 2 VCPUs/2GB RAM. >> > Thanks! > >> The results looked much better. >> > That's very good to hear. :-) > >> >> [snip] >> >> So without any deeper thinking this looks much better than the original >> version and possibly good enough for Xen 4.2. >> Maybe the automated testing finds some leftovers. >> > So, here's what we can do: > > 1) I can resend the series with this change in it (i.e., number of > domains weighting 3 times more than free memory); > > 2) I can resend the series like in 1) _but_ while also converting the > domain counting in vcpu counting (I checked that and it's trivial); > > 3) I can resend the series like in 1) and also send a separate patch > turning the domain counting in vcpu counting, and we can apply that > after it get some testing; > > Which one you like better? I'd prefer 2). To me it makes more sense and I can test it over the weekend and can send my acked-by on it. Regards, Andre. -- Andre Przywara AMD-OSRC (Dresden) Tel: x29712