From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v10 18/19] libxl: convert
 libxl_device_vfb_add to an async operation
Date: Mon, 23 Jul 2012 12:58:14 +0100
Message-ID: <500D3C56.30208@citrix.com>
References: <1342793548-10239-1-git-send-email-roger.pau@citrix.com>
	<1342793548-10239-19-git-send-email-roger.pau@citrix.com>
	<20489.40772.556450.864846@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20489.40772.556450.864846@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v10 18/19] libxl: convert libxl_device_vfb_add to an async operation"):
>> Split libxl_device_vfb_add into libxl__device_vfb_add (to be used
>> inside already running ao's), and make libxl_device_vfb_add a stub
>> to call libxl__device_vfb_add.
> 
> If I'm not mistaken this has the effect of newly waiting for vfbs to
> enter the correct state on xenstore.  Is that intentional ?

Yes, libxl waits for vfb to reach state 2 (InitWait), is that ok?

> If so it
> needs to be explained in the commit message.

Ok, I will rework on the commit message.

> Aside from that it looks plausible.
> 
> Thanks,
> Ian.