From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v11 01/17] libxl: fix stubdom console destruction Date: Tue, 24 Jul 2012 12:01:52 +0100 Message-ID: <500E80A0.60306@citrix.com> References: <1343064465-17864-1-git-send-email-roger.pau@citrix.com> <1343064465-17864-2-git-send-email-roger.pau@citrix.com> <1343116236.8016.24.camel@dagon.hellion.org.uk> <500E5F5D.1000601@citrix.com> <500E7F03.2050903@citrix.com> <1343127442.18971.7.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1343127442.18971.7.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > On Tue, 2012-07-24 at 11:54 +0100, Roger Pau Monne wrote: >>>>> Does it apply to LIBXL__CONSOLE_BACKEND_IOEMU as well >>>>> as ..._XENCONSOLED? I took a look through tools/console and I cannot >>>>> find any handling of a state node in xenstore at all, so the XENCONSOLED >>>>> case seems clear. I notice that xen_console.c registers the device with >>>>> DEVOPS_FLAG_IGNORE_STATE but that only seems to affect startup not >>>>> teardown. I don't see a qemu_chr_close (or anything similar) anywhere in >>>>> hw/xen_console.c >>>> So it should apply to any console device? This means I don't have to >>>> wait for any device of type LIBXL__DEVICE_KIND_CONSOLE, and there's no >>>> need to check for the specific console type or Qemu. >>> xen_console registers a disconnect handler, con_disconnect, that should >>> be able to unbind the evtchn and unmap the ring. >>> "disconnect" is called by xen_backend, if the backend and frontend >>> states are 5 or 6. >> Yes, but I don't see that con_disconnect sets the state to 6 after doing >> the cleanup, neither xenconsoled does so. I think con_disconnect should >> set xendev->be_state = 6, so the parent function xen_be_disconnect would >> notice the state change and write it to xenstore. >> > > The caller in xen_backend.c does this. The caller is xen_be_disconnect, which doesn't seem to change the state, and the caller of xen_be_disconnect is xen_be_check_state which also doesn't seem to change the state.