From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v11 15/17] libxl: convert libxl_device_vfb_add to an async operation Date: Wed, 25 Jul 2012 12:00:36 +0100 Message-ID: <500FD1D4.9040904@citrix.com> References: <1343064465-17864-1-git-send-email-roger.pau@citrix.com> <1343064465-17864-16-git-send-email-roger.pau@citrix.com> <20494.48475.670075.561834@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20494.48475.670075.561834@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v11 15/17] libxl: convert libxl_device_vfb_add to an async operation"): >> Split libxl_device_vfb_add into libxl__device_vfb_add (to be used >> inside already running ao's), and make libxl_device_vfb_add a stub >> to call libxl__device_vfb_add. >> >> Once the device has been added to xenstore, libxl waits for it to >> reach state 2 (InitWait). > > We will need to test this but it looks reasonable then. > > Acked-by: Ian Jackson I'm not going to take the Ack for this, because I've simplified libxl__device_vfb_add to not take any aodev/ao, since there's no point in waiting for vfb/vkb devices to switch to state 2 because we are not going to execute any hotplug script (as we spoke yesterday). The resulting patch is much more simple, sorry for the double work, and thanks for the review.