xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Santosh Jodh <santosh.jodh@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"xiantao.zhang@intel.com" <xiantao.zhang@intel.com>
Subject: Re: [PATCH] Intel VT-d: Dump IOMMU supported page sizes
Date: Tue, 31 Jul 2012 10:27:51 +0100	[thread overview]
Message-ID: <5017A517.4040300@citrix.com> (raw)
In-Reply-To: <6feac926cf80d9c23dd0.1343688075@REDBLD-XS.ad.xensource.com>

On 30/07/12 23:41, Santosh Jodh wrote:
> diff -r e6266fc76d08 -r 6feac926cf80 xen/drivers/passthrough/vtd/iommu.c
> --- a/xen/drivers/passthrough/vtd/iommu.c	Fri Jul 27 12:22:13 2012 +0200
> +++ b/xen/drivers/passthrough/vtd/iommu.c	Mon Jul 30 15:35:16 2012 -0700
> @@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
>      {
>          iommu = drhd->iommu;
>  
> +        printk("Intel VT-d supported page sizes: 4kB");
> +        if (cap_sps_2mb(iommu->cap))
> +            printk(", 2MB");
> +
> +        if (cap_sps_1gb(iommu->cap))
> +            printk(", 1GB");
> +
> +        printk(".\n");
> +
>          if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
>              iommu_snoop = 0;
>  
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

While the contents of this patch looks fine, and in line with c/s
24992:0384f791e538 which does the same for HAP page sizes, patches for
Xen should follow the format described at
http://wiki.xen.org/wiki/Submitting_Xen_Patches (specifically with a
description and a Signed-off-by line)

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

  reply	other threads:[~2012-07-31  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 22:41 [PATCH] Intel VT-d: Dump IOMMU supported page sizes Santosh Jodh
2012-07-31  9:27 ` Andrew Cooper [this message]
2012-07-31 15:08   ` Santosh Jodh
  -- strict thread matches above, loose matches on Subject: below --
2012-07-31 15:08 Santosh Jodh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5017A517.4040300@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=santosh.jodh@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).