* [PATCH] Intel VT-d: Dump IOMMU supported page sizes
@ 2012-07-30 22:41 Santosh Jodh
2012-07-31 9:27 ` Andrew Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Santosh Jodh @ 2012-07-30 22:41 UTC (permalink / raw)
To: xen-devel; +Cc: xiantao.zhang
diff -r e6266fc76d08 -r 6feac926cf80 xen/drivers/passthrough/vtd/iommu.c
--- a/xen/drivers/passthrough/vtd/iommu.c Fri Jul 27 12:22:13 2012 +0200
+++ b/xen/drivers/passthrough/vtd/iommu.c Mon Jul 30 15:35:16 2012 -0700
@@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
{
iommu = drhd->iommu;
+ printk("Intel VT-d supported page sizes: 4kB");
+ if (cap_sps_2mb(iommu->cap))
+ printk(", 2MB");
+
+ if (cap_sps_1gb(iommu->cap))
+ printk(", 1GB");
+
+ printk(".\n");
+
if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
iommu_snoop = 0;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Intel VT-d: Dump IOMMU supported page sizes
2012-07-30 22:41 [PATCH] Intel VT-d: Dump IOMMU supported page sizes Santosh Jodh
@ 2012-07-31 9:27 ` Andrew Cooper
2012-07-31 15:08 ` Santosh Jodh
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cooper @ 2012-07-31 9:27 UTC (permalink / raw)
To: Santosh Jodh; +Cc: xen-devel@lists.xensource.com, xiantao.zhang@intel.com
On 30/07/12 23:41, Santosh Jodh wrote:
> diff -r e6266fc76d08 -r 6feac926cf80 xen/drivers/passthrough/vtd/iommu.c
> --- a/xen/drivers/passthrough/vtd/iommu.c Fri Jul 27 12:22:13 2012 +0200
> +++ b/xen/drivers/passthrough/vtd/iommu.c Mon Jul 30 15:35:16 2012 -0700
> @@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
> {
> iommu = drhd->iommu;
>
> + printk("Intel VT-d supported page sizes: 4kB");
> + if (cap_sps_2mb(iommu->cap))
> + printk(", 2MB");
> +
> + if (cap_sps_1gb(iommu->cap))
> + printk(", 1GB");
> +
> + printk(".\n");
> +
> if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
> iommu_snoop = 0;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
While the contents of this patch looks fine, and in line with c/s
24992:0384f791e538 which does the same for HAP page sizes, patches for
Xen should follow the format described at
http://wiki.xen.org/wiki/Submitting_Xen_Patches (specifically with a
description and a Signed-off-by line)
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Intel VT-d: Dump IOMMU supported page sizes
2012-07-31 9:27 ` Andrew Cooper
@ 2012-07-31 15:08 ` Santosh Jodh
0 siblings, 0 replies; 4+ messages in thread
From: Santosh Jodh @ 2012-07-31 15:08 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel@lists.xensource.com, xiantao.zhang@intel.com
Doh! Resending...
Thanks,
Santosh
-----Original Message-----
From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
Sent: Tuesday, July 31, 2012 2:28 AM
To: Santosh Jodh
Cc: xen-devel@lists.xensource.com; xiantao.zhang@intel.com
Subject: Re: [Xen-devel] [PATCH] Intel VT-d: Dump IOMMU supported page sizes
On 30/07/12 23:41, Santosh Jodh wrote:
> diff -r e6266fc76d08 -r 6feac926cf80 xen/drivers/passthrough/vtd/iommu.c
> --- a/xen/drivers/passthrough/vtd/iommu.c Fri Jul 27 12:22:13 2012 +0200
> +++ b/xen/drivers/passthrough/vtd/iommu.c Mon Jul 30 15:35:16 2012 -0700
> @@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
> {
> iommu = drhd->iommu;
>
> + printk("Intel VT-d supported page sizes: 4kB");
> + if (cap_sps_2mb(iommu->cap))
> + printk(", 2MB");
> +
> + if (cap_sps_1gb(iommu->cap))
> + printk(", 1GB");
> +
> + printk(".\n");
> +
> if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
> iommu_snoop = 0;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
While the contents of this patch looks fine, and in line with c/s
24992:0384f791e538 which does the same for HAP page sizes, patches for Xen should follow the format described at http://wiki.xen.org/wiki/Submitting_Xen_Patches (specifically with a description and a Signed-off-by line)
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Intel VT-d: Dump IOMMU supported page sizes
@ 2012-07-31 15:08 Santosh Jodh
0 siblings, 0 replies; 4+ messages in thread
From: Santosh Jodh @ 2012-07-31 15:08 UTC (permalink / raw)
To: xen-devel; +Cc: xiantao.zhang
Signed-off-by: Santosh Jodh <santosh.jodh@citrix.com>
diff -r e6266fc76d08 -r 33dcecf4e454 xen/drivers/passthrough/vtd/iommu.c
--- a/xen/drivers/passthrough/vtd/iommu.c Fri Jul 27 12:22:13 2012 +0200
+++ b/xen/drivers/passthrough/vtd/iommu.c Tue Jul 31 08:08:06 2012 -0700
@@ -2137,6 +2137,15 @@ int __init intel_vtd_setup(void)
{
iommu = drhd->iommu;
+ printk("Intel VT-d supported page sizes: 4kB");
+ if (cap_sps_2mb(iommu->cap))
+ printk(", 2MB");
+
+ if (cap_sps_1gb(iommu->cap))
+ printk(", 1GB");
+
+ printk(".\n");
+
if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
iommu_snoop = 0;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-31 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-30 22:41 [PATCH] Intel VT-d: Dump IOMMU supported page sizes Santosh Jodh
2012-07-31 9:27 ` Andrew Cooper
2012-07-31 15:08 ` Santosh Jodh
-- strict thread matches above, loose matches on Subject: below --
2012-07-31 15:08 Santosh Jodh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).