From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 5 of 5] makefile: Use $(abspath) for XEN_ROOT
Date: Tue, 31 Jul 2012 18:36:16 +0100
Message-ID: <50181790.6020600@citrix.com>
References: <patchbomb.1343749916@andrewcoop.uk.xensource.com>
	<c655330a5805dbbc63e2.1343749921@andrewcoop.uk.xensource.com>
	<501826420200007800091ADE@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <501826420200007800091ADE@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 31/07/12 17:38, Jan Beulich wrote:
>>>> On 31.07.12 at 17:52, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> This patch wraps the assignment of XEN_ROOT in each Makefile with a call to
>> $(abspath) which removes internal parent path references which result from 
>> the definition of XEN_ROOT as $(CURDIR)../../ (etc).
> Except that it's a make 3.81 invention, and so far we support
> building with make 3.80. So if you want to use it, you'll need to
> provide a fallback implementation (the placement of which may
> turn out to be problematic).
>
> Jan

Ah - so it is. 

Unfortunately, it appears hard to provide a backwards compatible way of
doing this.  Best to just forget this patch then, although it would be
nice to address this issue somehow in 4.3

~Andrew

>
>> For example, it changes the output from
>>
>>   gcc readnotes.o -o readnotes
>>   /bind/myrepos/xen-unstable.hg/tools/xcutils/../../tools/libxc/libxenctrl.so
>>   
>> /bind/myrepos/xen-unstable.hg/tools/xcutils/../../tools/libxc/libxenguest.so
>>
>> to
>>
>>   gcc readnotes.o -o readnotes 
>> /bind/myrepos/xen-unstable.hg/tools/libxc/libxenctrl.so
>>   /bind/myrepos/xen-unstable.hg/tools/libxc/libxenguest.so
>>
>> which decreases verbosity and increases clarity when reading the build log.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com