Re: [PATCH 4 of 5] xen/makefile: Allow XEN_CHANGESET to be set externally

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 02/08/12 14:35, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH 4 of 5] xen/makefile: Allow XEN_CHANGESET to be set externally"):
>> # compile.h contains dynamic build info. Rebuilt on every 'make'
>> invocation.                                                                                                                                  
>>
>> include/xen/compile.h: include/xen/compile.h.in .banner
>>         @sed -e 's/@@date@@/$(shell LC_ALL=C date)/g' \
>>
>> So it should only be executed once (unless someone is messing around
>> deleting compile.h)
>>
>> Having said that, even if it were executed more than once, there is no
>> reasonable circumstance during which the contents of XEN_CHANGESET
>> should change.
> Uh, "hg up <changeset>", surely ?
>
> Ian.

Sure, but compile.h is regenerated on every invocation of Make

I should have stated that during an individual build there are no
reasonable circumstances.  Running an hg update during a build is asking
for trouble.

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com