From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 4 of 5] xen/makefile: Allow XEN_CHANGESET to be set externally Date: Thu, 2 Aug 2012 14:47:07 +0100 Message-ID: <501A84DB.3040101@citrix.com> References: <20504.3594.340410.435942@mariner.uk.xensource.com> <5018FBB60200007800091CCB@nat28.tlf.novell.com> <5018F7ED.3010100@citrix.com> <20506.33289.314238.601890@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20506.33289.314238.601890@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "Keir (Xen.org)" , Ian Campbell , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 02/08/12 14:35, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH 4 of 5] xen/makefile: Allow XEN_CHANGESET to be set externally"): >> # compile.h contains dynamic build info. Rebuilt on every 'make' >> invocation. >> >> include/xen/compile.h: include/xen/compile.h.in .banner >> @sed -e 's/@@date@@/$(shell LC_ALL=C date)/g' \ >> >> So it should only be executed once (unless someone is messing around >> deleting compile.h) >> >> Having said that, even if it were executed more than once, there is no >> reasonable circumstance during which the contents of XEN_CHANGESET >> should change. > Uh, "hg up ", surely ? > > Ian. Sure, but compile.h is regenerated on every invocation of Make I should have stated that during an individual build there are no reasonable circumstances. Running an hg update during a build is asking for trouble. -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com