From: George Dunlap <george.dunlap@eu.citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Tim (Xen.org)" <tim@xen.org>,
Andres Lagar-Cavilla <andres@lagarcavilla.org>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/PoD: fix (un)locking after 24772:28edc2b31a9b
Date: Mon, 13 Aug 2012 13:42:07 +0100 [thread overview]
Message-ID: <5028F61F.6080403@eu.citrix.com> (raw)
In-Reply-To: <50290B0C0200007800094750@nat28.tlf.novell.com>
On 13/08/12 13:11, Jan Beulich wrote:
> That c/s introduced a double unlock on the out-of-memory error path of
> p2m_pod_demand_populate().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Good catch.
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
>
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -1075,6 +1075,7 @@ out_of_memory:
> printk("%s: Out of populate-on-demand memory! tot_pages %" PRIu32 " pod_entries %" PRIi32 "\n",
> __func__, d->tot_pages, p2m->pod.entry_count);
> domain_crash(d);
> + return -1;
> out_fail:
> pod_unlock(p2m);
> return -1;
>
>
>
next prev parent reply other threads:[~2012-08-13 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 12:11 [PATCH] x86/PoD: fix (un)locking after 24772:28edc2b31a9b Jan Beulich
2012-08-13 12:42 ` George Dunlap [this message]
2012-08-13 13:43 ` Andres Lagar-Cavilla
2012-08-13 14:50 ` Jan Beulich
2012-08-13 15:22 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5028F61F.6080403@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andres@lagarcavilla.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).