From: Christoph Egger <Christoph.Egger@amd.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: xl segfault when starting a guest
Date: Mon, 13 Aug 2012 15:55:57 +0200 [thread overview]
Message-ID: <5029076D.2090803@amd.com> (raw)
In-Reply-To: <20511.54333.44714.694390@mariner.uk.xensource.com>
On 08/06/12 16:27, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] xl segfault when starting a guest"):
>> It looks like 25727:a8d708fcb347 is missing some bits of my original
>> patch got missed during application, specifically the changes to the
>> iscsi/nbd/enbd prefix handling rule.
>
> This was because:
> - I mistakenly used the copy of the patch that Ian C had CC'd to me,
> rather than the copy I got via the mailing list. The former went
> via the Citrix corporate email system which mangles things, which
> is why this is a bad idea. The latter does not.
> - When I tried to apply it, it produced a bunch of rejects in the
> autogenerated files. However buried in those messages was a reject
> in the .l source file, which I didn't spot.
> - I therefore tried to regenerate the flex source (perhaps not with
> complete success) and committed the result.
> Sorry for messing this up.
>
> I have backed out 25727:a8d708fcb347 and reapplied what I think is a
> non-mangled version as 25733:353bc0801b11.
Works for me. Thanks.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
prev parent reply other threads:[~2012-08-13 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 14:24 xl segfault when starting a guest Christoph Egger
2012-08-03 14:45 ` Ian Campbell
2012-08-03 15:14 ` Christoph Egger
2012-08-06 9:13 ` Ian Campbell
2012-08-06 11:36 ` Ian Campbell
2012-08-06 14:27 ` Ian Jackson
2012-08-13 13:55 ` Christoph Egger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5029076D.2090803@amd.com \
--to=christoph.egger@amd.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).