xl segfault when starting a guest

xl segfault when starting a guest

[Christoph Egger]

Hi,

I installed c/s 25729 and xl crashes.
The prior c/s I used was 25687 and worked fine.
I can't find any c/s that could touch libxl in such a way.

xl segfaults with xl create.


# gdb xl
GNU gdb (GDB) 7.3.1
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64--netbsd".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /usr/local.25729/sbin/xl...done.
(gdb) set args -vvv create -c /hvm-guest/win2008.conf
(gdb) run
Starting program: /usr/local.25729/sbin/xl create -c /hvm-guest/win2008.conf
Parsing config from /hvm-guest/win2008.conf

Program received signal SIGSEGV, Segmentation fault.
0x00007f7ff7806c57 in xlu__disk_yylex (yyscanner=0x7f7ff7b1f0c0)
    at libxlu_disk_l.c:1195
1195    libxlu_disk_l.c: No such file or directory.
        in libxlu_disk_l.c
(gdb) bt
#0  0x00007f7ff7806c57 in xlu__disk_yylex (yyscanner=0x7f7ff7b1f0c0)
    at libxlu_disk_l.c:1195
#1  0x00007f7ff7807d28 in xlu_disk_parse (cfg=<optimized out>, nspecs=1,
    specs=<optimized out>, disk=0x7f7ff7b24080) at libxlu_disk.c:66
#2  0x0000000000408213 in parse_disk_config_multistring
(config=0x7f7fffffd158,
    nspecs=1, specs=0x7f7fffffd0b8, disk=0x7f7ff7b24080) at xl_cmdimpl.c:423
#3  0x0000000000408284 in parse_disk_config (config=<optimized out>,
    spec=0x7f7ff7b01500 "file:/hvm-guest/win2008.img,ioemu:hda,w",
    disk=<optimized out>) at xl_cmdimpl.c:434
#4  0x000000000040a905 in parse_config_data (config_source=<optimized out>,
    config_data=<optimized out>, config_len=<optimized out>,
    d_config=0x7f7fffffd340, dom_info=<optimized out>) at xl_cmdimpl.c:920
#5  0x000000000040c35e in create_domain (dom_info=0x7f7fffffd610)
    at xl_cmdimpl.c:1742
#6  0x0000000000410466 in main_create (argc=3, argv=<optimized out>)
    at xl_cmdimpl.c:3771
#7  0x0000000000406f55 in main (argc=3, argv=0x7f7fffffdb68) at xl.c:267
(gdb)



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: xl segfault when starting a guest

[Ian Campbell]

On Fri, 2012-08-03 at 15:24 +0100, Christoph Egger wrote:
> Hi,
> 
> I installed c/s 25729 and xl crashes.
> The prior c/s I used was 25687 and worked fine.

These number can be ambiguous, what are the long hashes?

> I can't find any c/s that could touch libxl in such a way.

Me neither, but the xlu disk parser has been touched recently, e.g.
25727:a8d708fcb347 is in there.

Recently there was 25665:fab03d9ee1ba and 25663:968b205da696 too.

A dry run with your syntax seems to work for me e.g. :
        xl -N block-attach 0 'file:/hvm-guest/win2008.img,ioemu:hda,w'

Did the generated flex files get rebuilt in your environment?

> Starting program: /usr/local.25729/sbin/xl create -c /hvm-guest/win2008.conf

Can you send win2008.conf please.

Does a dry run create reproduce it? xl -N create .../win2008.conf --
that'll be easier for me to repro.

Is this under NetBSD?

Ian.

Re: xl segfault when starting a guest

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]

On 08/03/12 16:45, Ian Campbell wrote:

> On Fri, 2012-08-03 at 15:24 +0100, Christoph Egger wrote:
>> Hi,
>>
>> I installed c/s 25729 and xl crashes.
>> The prior c/s I used was 25687 and worked fine.
> 
> These number can be ambiguous, what are the long hashes?


25729:6ccad16b50b6
25687:fab4434f5145

> 
>> I can't find any c/s that could touch libxl in such a way.
> 
> Me neither, but the xlu disk parser has been touched recently, e.g.
> 25727:a8d708fcb347 is in there.

Yes, that's it.
Reverting this changeset makes xl work again for me.


> Recently there was 25665:fab03d9ee1ba and 25663:968b205da696 too.
> 
> A dry run with your syntax seems to work for me e.g. :
>         xl -N block-attach 0 'file:/hvm-guest/win2008.img,ioemu:hda,w'


This also crashes for me but works for me with c/s 25727:a8d708fcb347
reverted.
xl info works.

 
> Did the generated flex files get rebuilt in your environment?
> 
>> Starting program: /usr/local.25729/sbin/xl create -c /hvm-guest/win2008.conf
> 
> Can you send win2008.conf please.


Attached.

> 
> Does a dry run create reproduce it? xl -N create .../win2008.conf --
> that'll be easier for me to repro.


Yes.

 
> Is this under NetBSD?


Yes.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: win2008.conf --]
[-- Type: text/plain, Size: 7318 bytes --]

#  -*- mode: python; -*-
#============================================================================
# Python configuration setup for 'xm create'.
# This script sets the parameters used when a domain is created using 'xm create'.
# You use a separate script for each domain you want to create, or 
# you can set the parameters for the domain on the xm command line.
#============================================================================

#----------------------------------------------------------------------------
# Kernel image file.
#kernel = "hvmloader"

# The domain build function. HVM domain uses 'hvm'.
builder='hvm'

# Initial memory allocation (in megabytes) for the new domain.
#
# WARNING: Creating a domain with insufficient memory may cause out of
#          memory errors. The domain needs enough memory to boot kernel
#          and modules. Allocating less than 32MBs is not recommended.
#memory = 6500
#memory = 512
#memory = 2048
memory = 3072

nestedhvm=1

# Shadow pagetable memory for the domain, in MB.
# Should be at least 2KB per MB of domain memory, plus a few MB per vcpu.
#shadow_memory = 20

# A name for your domain. All domains must have different names.
name = "win2008"

# 128-bit UUID for the domain.  The default behavior is to generate a new UUID
# on each call to 'xm create'.
#uuid = "06ed00fe-1162-4fc4-b5d8-11993ee4a8b9"

#-----------------------------------------------------------------------------
# the number of cpus guest platform has, default=1
vcpus=1

# enable/disable HVM guest PAE, default=0 (disabled)
#pae=1

# enable/disable HVM guest ACPI, default=0 (disabled)
acpi=1

# enable/disable HVM guest APIC, default=0 (disabled)
apic=1

#cpuid="host,page1gb=k,hypervisor=0,svm_npt=0"
cpuid="host,page1gb=k,hypervisor=0"

# List of which CPUS this domain is allowed to use, default Xen picks
#cpus = ""         # leave to Xen to pick
#cpus = "0"        # all vcpus run on CPU0
#cpus = "0-3,5,^1" # run on cpus 0,2,3,5
#cpus = "2-3"

# Optionally define mac and/or bridge for the network interfaces.
# Random MACs are assigned if not given.
#vif = [ 'type=ioemu, mac=00:16:3e:00:ce:a3, bridge=bridge0, model=ne2k_pci' ]
# type=ioemu specify the NIC is an ioemu device not netfront
vif = [ 'type=ioemu, mac=00:16:3e:01:ce:a3, bridge=bridge0, model=e1000'  ]

#----------------------------------------------------------------------------
# Define the disk devices you want the domain to have access to, and
# what you want them accessible as.
# Each disk entry is of the form phy:UNAME,DEV,MODE
# where UNAME is the device, DEV is the device name the domain will see,
# and MODE is r for read-only, w for read-write.

disk = [ 'file:/hvm-guest/win2008.img,ioemu:hda,w', 'file:/hvm-guest/win2008.iso,hdc:cdrom,r' ] 

#----------------------------------------------------------------------------
# Configure the behaviour when a domain exits.  There are three 'reasons'
# for a domain to stop: poweroff, reboot, and crash.  For each of these you
# may specify:
#
#   "destroy",        meaning that the domain is cleaned up as normal;
#   "restart",        meaning that a new domain is started in place of the old
#                     one;
#   "preserve",       meaning that no clean-up is done until the domain is
#                     manually destroyed (using xm destroy, for example); or
#   "rename-restart", meaning that the old domain is not cleaned up, but is
#                     renamed and a new domain started in its place.
#
# The default is
#
#   on_poweroff = 'destroy'
#   on_reboot   = 'restart'
#   on_crash    = 'restart'
#
# For backwards compatibility we also support the deprecated option restart
#
# restart = 'onreboot' means on_poweroff = 'destroy'
#                            on_reboot   = 'restart'
#                            on_crash    = 'destroy'
#
# restart = 'always'   means on_poweroff = 'restart'
#                            on_reboot   = 'restart'
#                            on_crash    = 'restart'
#
# restart = 'never'    means on_poweroff = 'destroy'
#                            on_reboot   = 'destroy'
#                            on_crash    = 'destroy'

#on_poweroff = 'destroy'
#on_reboot   = 'restart'
#on_crash    = 'restart'
#on_poweroff = 'preserve'
#on_reboot   = 'preserve'
#on_crash    = 'preserve'
on_crash    = 'destroy'
on_poweroff = 'destroy'
on_reboot = 'destroy'

#============================================================================

# Device Model
#device_model = 'qemu-dm'

#-----------------------------------------------------------------------------
# boot on floppy (a), hard disk (c) or CD-ROM (d) 
# default: hard disk, cd-rom, floppy
boot="cd"
#boot="dc"

#-----------------------------------------------------------------------------
#  write to temporary files instead of disk image files
#snapshot=1

#----------------------------------------------------------------------------
# enable SDL library for graphics, default = 0
sdl=0

#----------------------------------------------------------------------------
# enable VNC library for graphics, default = 1
vnc=1

#----------------------------------------------------------------------------
# address that should be listened on for the VNC server if vnc is set.
# default is to use 'vnc-listen' setting from /etc/xen/xend-config.sxp
vnclisten="0.0.0.0"

#----------------------------------------------------------------------------
# set VNC display number, default = domid
#vncdisplay=1

#----------------------------------------------------------------------------
# try to find an unused port for the VNC server, default = 1
#vncunused=1

#----------------------------------------------------------------------------
# enable spawning vncviewer for domain's console
# (only valid when vnc=1), default = 0
#vncconsole=0

#----------------------------------------------------------------------------
# set password for domain's VNC console
# default is depents on vncpasswd in xend-config.sxp
vncpasswd=''

#----------------------------------------------------------------------------
# no graphics, use serial port
nographic=0

#----------------------------------------------------------------------------
# enable stdvga, default = 0 (use cirrus logic device model)
stdvga=1

#-----------------------------------------------------------------------------
#   serial port re-direct to pty deivce, /dev/pts/n 
#   then xm console or minicom can connect
#serial='pty'


#-----------------------------------------------------------------------------
#   enable sound card support, [sb16|es1370|all|..,..], default none
#soundhw='sb16'


#-----------------------------------------------------------------------------
#    set the real time clock to local time [default=0 i.e. set to utc]
#localtime=1


#-----------------------------------------------------------------------------
#    start in full screen
#full-screen=1   


#-----------------------------------------------------------------------------
#   Enable USB support (specific devices specified at runtime through the
#			monitor window)
#usb=1
usb=1

#   Enable USB mouse support (only enable one of the following, `mouse' for
#			      PS/2 protocol relative mouse, `tablet' for
#			      absolute mouse)
#usbdevice='mouse'
usbdevice='tablet'


#viridian=1
#hpet=0

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: xl segfault when starting a guest

[Ian Campbell]

> > A dry run with your syntax seems to work for me e.g. :
> >         xl -N block-attach 0 'file:/hvm-guest/win2008.img,ioemu:hda,w'
> 
> 
> This also crashes for me but works for me with c/s 25727:a8d708fcb347
> reverted.

I can somehow repro this morning too.

It looks like 25727:a8d708fcb347 is missing some bits of my original
patch got missed during application, specifically the changes to the
iscsi/nbd/enbd prefix handling rule.

Putting that back fixes the issue, although I can't exactly see why, so
I'm suspicious of IanJ's flex rerun (as noted in the commit log). We
both typically use Debian Squeeze and my patch included the regenerated
files so I would have expected no change.

8<------------------------------------------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1344244364 -3600
# Node ID 0dd09d4825a685f1f02560e6201533220ecbfa1f
# Parent  923a7fd08d5e6647a1ed91fcfdeecd9f59aa54fc
libxl: re-apply missing bits of  25739:1781892b19f8 (block script support)

The parts of this patch relating to the following changes were some
how missed during application

   This highlighted two bugs in the libxlu disk parser handling of the
   deprecated "<script>:" prefix:

   - It was failing to prefix with "block-" to construct the actual
     script name

   - The regex for matching iscsi or drdb or e?nbd was incorrect

For some reason this seems to have caused xl to segfault although I
can't see why this would be the case.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r 923a7fd08d5e -r 0dd09d4825a6 tools/libxl/libxlu_disk_l.c
--- a/tools/libxl/libxlu_disk_l.c	Mon Aug 06 10:04:59 2012 +0100
+++ b/tools/libxl/libxlu_disk_l.c	Mon Aug 06 10:12:44 2012 +0100
@@ -370,7 +370,7 @@ struct yy_trans_info
 	flex_int32_t yy_verify;
 	flex_int32_t yy_nxt;
 	};
-static yyconst flex_int16_t yy_acclist[456] =
+static yyconst flex_int16_t yy_acclist[447] =
     {   0,
        24,   24,   26,   22,   23,   25, 8193,   22,   23,   25,
     16385, 8193,   22,   25,16385,   22,   23,   25,   23,   25,
@@ -1188,14 +1188,14 @@ yy_match:
 			while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 				{
 				yy_current_state = (int) yy_def[yy_current_state];
-				if ( yy_current_state >= 256 )
+				if ( yy_current_state >= 251 )
 					yy_c = yy_meta[(unsigned int) yy_c];
 				}
 			yy_current_state = yy_nxt[yy_base[yy_current_state] + (unsigned int) yy_c];
 			*yyg->yy_state_ptr++ = yy_current_state;
 			++yy_cp;
 			}
-		while ( yy_current_state != 255 );
+		while ( yy_current_state != 250 );
 
 yy_find_action:
 		yy_current_state = *--yyg->yy_state_ptr;
@@ -1245,72 +1245,72 @@ do_action:	/* This label is used only to
 case 1:
 /* rule 1 can match eol */
 YY_RULE_SETUP
-#line 155 "libxlu_disk_l.l"
+#line 159 "libxlu_disk_l.l"
 { /* ignore whitespace before parameters */ }
 	YY_BREAK
 /* ordinary parameters setting enums or strings */
 case 2:
 /* rule 2 can match eol */
 YY_RULE_SETUP
-#line 159 "libxlu_disk_l.l"
+#line 163 "libxlu_disk_l.l"
 { STRIP(','); setformat(DPC, FROMEQUALS); }
 	YY_BREAK
 case 3:
 YY_RULE_SETUP
-#line 161 "libxlu_disk_l.l"
+#line 165 "libxlu_disk_l.l"
 { DPC->disk->is_cdrom = 1; }
 	YY_BREAK
 case 4:
 YY_RULE_SETUP
-#line 162 "libxlu_disk_l.l"
+#line 166 "libxlu_disk_l.l"
 { DPC->disk->is_cdrom = 1; }
 	YY_BREAK
 case 5:
 YY_RULE_SETUP
-#line 163 "libxlu_disk_l.l"
+#line 167 "libxlu_disk_l.l"
 { DPC->disk->is_cdrom = 0; }
 	YY_BREAK
 case 6:
 /* rule 6 can match eol */
 YY_RULE_SETUP
-#line 164 "libxlu_disk_l.l"
+#line 168 "libxlu_disk_l.l"
 { xlu__disk_err(DPC,yytext,"unknown value for type"); }
 	YY_BREAK
 case 7:
 /* rule 7 can match eol */
 YY_RULE_SETUP
-#line 166 "libxlu_disk_l.l"
+#line 170 "libxlu_disk_l.l"
 { STRIP(','); setaccess(DPC, FROMEQUALS); }
 	YY_BREAK
 case 8:
 /* rule 8 can match eol */
 YY_RULE_SETUP
-#line 167 "libxlu_disk_l.l"
+#line 171 "libxlu_disk_l.l"
 { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
 	YY_BREAK
 case 9:
 /* rule 9 can match eol */
 YY_RULE_SETUP
-#line 169 "libxlu_disk_l.l"
+#line 173 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
 	YY_BREAK
 case 10:
 /* rule 10 can match eol */
 YY_RULE_SETUP
-#line 170 "libxlu_disk_l.l"
+#line 174 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("script", script, FROMEQUALS); }
 	YY_BREAK
 /* the target magic parameter, eats the rest of the string */
 case 11:
 YY_RULE_SETUP
-#line 174 "libxlu_disk_l.l"
+#line 178 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); }
 	YY_BREAK
 /* unknown parameters */
 case 12:
 /* rule 12 can match eol */
 YY_RULE_SETUP
-#line 178 "libxlu_disk_l.l"
+#line 182 "libxlu_disk_l.l"
 { xlu__disk_err(DPC,yytext,"unknown parameter"); }
 	YY_BREAK
 /* deprecated prefixes */
@@ -1327,24 +1327,31 @@ YY_RULE_SETUP
 	YY_BREAK
 case 14:
 YY_RULE_SETUP
-#line 191 "libxlu_disk_l.l"
+#line 195 "libxlu_disk_l.l"
 {
-		    STRIP(':');
+                    char *newscript;
+                    STRIP(':');
                     DPC->had_depr_prefix=1; DEPRECATE("use `script=...'");
-		    SAVESTRING("script", script, yytext);
-		}
+                    if (asprintf(&newscript, "block-%s", yytext) < 0) {
+                            xlu__disk_err(DPC,yytext,"unable to format script");
+                            return 0;
+                    }
+                    savestring(DPC, "script respecified",
+                               &DPC->disk->script, newscript);
+                    free(newscript);
+                }
 	YY_BREAK
 case 15:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
 yyg->yy_c_buf_p = yy_cp = yy_bp + 8;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 197 "libxlu_disk_l.l"
+#line 208 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
 case 16:
 YY_RULE_SETUP
-#line 198 "libxlu_disk_l.l"
+#line 209 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
 case 17:
@@ -1376,13 +1383,13 @@ case 20:
 yyg->yy_c_buf_p = yy_cp = yy_bp + 4;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 202 "libxlu_disk_l.l"
+#line 213 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
 case 21:
 /* rule 21 can match eol */
 YY_RULE_SETUP
-#line 204 "libxlu_disk_l.l"
+#line 215 "libxlu_disk_l.l"
 {
 		  xlu__disk_err(DPC,yytext,"unknown deprecated disk prefix");
 		  return 0;
@@ -1429,17 +1436,17 @@ YY_RULE_SETUP
 	YY_BREAK
 case 24:
 YY_RULE_SETUP
-#line 241 "libxlu_disk_l.l"
+#line 252 "libxlu_disk_l.l"
 {
     xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0;
 }
 	YY_BREAK
 case 25:
 YY_RULE_SETUP
-#line 244 "libxlu_disk_l.l"
+#line 255 "libxlu_disk_l.l"
 YY_FATAL_ERROR( "flex scanner jammed" );
 	YY_BREAK
-#line 1445 "libxlu_disk_l.c"
+#line 1450 "libxlu_disk_l.c"
 			case YY_STATE_EOF(INITIAL):
 			case YY_STATE_EOF(LEXERR):
 				yyterminate();
@@ -1703,7 +1710,7 @@ static int yy_get_next_buffer (yyscan_t 
 		while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 			{
 			yy_current_state = (int) yy_def[yy_current_state];
-			if ( yy_current_state >= 256 )
+			if ( yy_current_state >= 251 )
 				yy_c = yy_meta[(unsigned int) yy_c];
 			}
 		yy_current_state = yy_nxt[yy_base[yy_current_state] + (unsigned int) yy_c];
@@ -1727,11 +1734,11 @@ static int yy_get_next_buffer (yyscan_t 
 	while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 		{
 		yy_current_state = (int) yy_def[yy_current_state];
-		if ( yy_current_state >= 256 )
+		if ( yy_current_state >= 251 )
 			yy_c = yy_meta[(unsigned int) yy_c];
 		}
 	yy_current_state = yy_nxt[yy_base[yy_current_state] + (unsigned int) yy_c];
-	yy_is_jam = (yy_current_state == 255);
+	yy_is_jam = (yy_current_state == 250);
 	if ( ! yy_is_jam )
 		*yyg->yy_state_ptr++ = yy_current_state;
 
diff -r 923a7fd08d5e -r 0dd09d4825a6 tools/libxl/libxlu_disk_l.l
--- a/tools/libxl/libxlu_disk_l.l	Mon Aug 06 10:04:59 2012 +0100
+++ b/tools/libxl/libxlu_disk_l.l	Mon Aug 06 10:12:44 2012 +0100
@@ -192,11 +192,18 @@ target=.*	{ STRIP(','); SAVESTRING("targ
                     setformat(DPC, yytext);
                  }
 
-iscsi:|e?nbd:drbd:/.* {
-		    STRIP(':');
+(iscsi|e?nbd|drbd):/.* {
+                    char *newscript;
+                    STRIP(':');
                     DPC->had_depr_prefix=1; DEPRECATE("use `script=...'");
-		    SAVESTRING("script", script, yytext);
-		}
+                    if (asprintf(&newscript, "block-%s", yytext) < 0) {
+                            xlu__disk_err(DPC,yytext,"unable to format script");
+                            return 0;
+                    }
+                    savestring(DPC, "script respecified",
+                               &DPC->disk->script, newscript);
+                    free(newscript);
+                }
 
 tapdisk:/.*	{ DPC->had_depr_prefix=1; DEPRECATE(0); }
 tap2?:/.*	{ DPC->had_depr_prefix=1; DEPRECATE(0); }

Re: xl segfault when starting a guest

[Ian Campbell]

On Mon, 2012-08-06 at 10:13 +0100, Ian Campbell wrote:

> It looks like 25727:a8d708fcb347 is missing some bits of my original
> patch got missed during application, specifically the changes to the
> iscsi/nbd/enbd prefix handling rule.

Ian J has reverted 25727:a8d708fcb347 and re-committed the entire patch.
I hope this fixes the issue for you, it does for me.

Ian.

Re: xl segfault when starting a guest

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-devel] xl segfault when starting a guest"):
> It looks like 25727:a8d708fcb347 is missing some bits of my original
> patch got missed during application, specifically the changes to the
> iscsi/nbd/enbd prefix handling rule.

This was because:
 - I mistakenly used the copy of the patch that Ian C had CC'd to me,
   rather than the copy I got via the mailing list.  The former went
   via the Citrix corporate email system which mangles things, which
   is why this is a bad idea.  The latter does not.
 - When I tried to apply it, it produced a bunch of rejects in the
   autogenerated files.  However buried in those messages was a reject
   in the .l source file, which I didn't spot.
 - I therefore tried to regenerate the flex source (perhaps not with
   complete success) and committed the result. 
Sorry for messing this up.

I have backed out 25727:a8d708fcb347 and reapplied what I think is a
non-mangled version as 25733:353bc0801b11.

Ian.

Re: xl segfault when starting a guest

[Christoph Egger]

On 08/06/12 16:27, Ian Jackson wrote:

> Ian Campbell writes ("Re: [Xen-devel] xl segfault when starting a guest"):
>> It looks like 25727:a8d708fcb347 is missing some bits of my original
>> patch got missed during application, specifically the changes to the
>> iscsi/nbd/enbd prefix handling rule.
> 
> This was because:
>  - I mistakenly used the copy of the patch that Ian C had CC'd to me,
>    rather than the copy I got via the mailing list.  The former went
>    via the Citrix corporate email system which mangles things, which
>    is why this is a bad idea.  The latter does not.
>  - When I tried to apply it, it produced a bunch of rejects in the
>    autogenerated files.  However buried in those messages was a reject
>    in the .l source file, which I didn't spot.
>  - I therefore tried to regenerate the flex source (perhaps not with
>    complete success) and committed the result. 
> Sorry for messing this up.
> 
> I have backed out 25727:a8d708fcb347 and reapplied what I think is a
> non-mangled version as 25733:353bc0801b11.


Works for me. Thanks.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632