xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: (V2) tools/python: Clean python correctly
Date: Tue, 14 Aug 2012 17:54:50 +0100	[thread overview]
Message-ID: <502A82DA.7000205@citrix.com> (raw)
In-Reply-To: <502A5C58.5050001@citrix.com>

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

Attached version 2, because it seems that despite my testing, "python
setup.py clean" still doesn't actually clean enough.

On 14/08/12 15:10, Andrew Cooper wrote:
> I discovered this with repeated calls to "make clean; make dist-tools"
>
> An alternative, if you wish to remove the use of $(PYTHON) from the
> clean path is to just `rm -rf build`, but using setup.py seems neater.
>

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com


[-- Attachment #2: tools-python-clean.patch --]
[-- Type: text/x-patch, Size: 651 bytes --]

# HG changeset patch
# Parent 33d596f46521ea852e90cf6dbdbf3680d104134c
tools/python: Clean python correctly

Cleaning the python directory should call `$(PYTHON) setup.py clean`
which will clean the build/ subdirectory.  Otherwise, subsequent builds
may be short-circuited and a stale build installed.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff -r 33d596f46521 tools/python/Makefile
--- a/tools/python/Makefile
+++ b/tools/python/Makefile
@@ -33,6 +33,7 @@ test:
 
 .PHONY: clean
 clean:
+	$(PYTHON) setup.py clean --all
 	rm -f $(XENPATH)
 	rm -rf *.pyc *.pyo *.o *.a *~ xen/util/auxbin.pyc
 	rm -f xen/lowlevel/xl/_pyxl_types.h

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2012-08-14 16:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 14:10 tools/python: Clean python correctly Andrew Cooper
2012-08-14 16:54 ` Andrew Cooper [this message]
2012-08-14 17:34   ` (V2) " Ian Jackson
2012-08-14 17:41     ` Andrew Cooper
2012-08-14 17:45       ` (V3) " Andrew Cooper
2012-08-17 13:48         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502A82DA.7000205@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).