* tools/python: Clean python correctly
@ 2012-08-14 14:10 Andrew Cooper
2012-08-14 16:54 ` (V2) " Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2012-08-14 14:10 UTC (permalink / raw)
To: xen-devel@lists.xen.org, Ian Campbell, Ian Jackson
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
I discovered this with repeated calls to "make clean; make dist-tools"
An alternative, if you wish to remove the use of $(PYTHON) from the
clean path is to just `rm -rf build`, but using setup.py seems neater.
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
[-- Attachment #2: tools-python-clean.patch --]
[-- Type: text/x-patch, Size: 645 bytes --]
# HG changeset patch
# Parent 33d596f46521ea852e90cf6dbdbf3680d104134c
tools/python: Clean python correctly
Cleaning the python directory should call `$(PYTHON) setup.py clean`
which will clean the build/ subdirectory. Otherwise, subsequent builds
may be short-circuited and a stale build installed.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff -r 33d596f46521 tools/python/Makefile
--- a/tools/python/Makefile
+++ b/tools/python/Makefile
@@ -33,6 +33,7 @@ test:
.PHONY: clean
clean:
+ $(PYTHON) setup.py clean
rm -f $(XENPATH)
rm -rf *.pyc *.pyo *.o *.a *~ xen/util/auxbin.pyc
rm -f xen/lowlevel/xl/_pyxl_types.h
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (V2) tools/python: Clean python correctly
2012-08-14 14:10 tools/python: Clean python correctly Andrew Cooper
@ 2012-08-14 16:54 ` Andrew Cooper
2012-08-14 17:34 ` Ian Jackson
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2012-08-14 16:54 UTC (permalink / raw)
To: xen-devel@lists.xen.org, Ian Campbell, Ian Jackson
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
Attached version 2, because it seems that despite my testing, "python
setup.py clean" still doesn't actually clean enough.
On 14/08/12 15:10, Andrew Cooper wrote:
> I discovered this with repeated calls to "make clean; make dist-tools"
>
> An alternative, if you wish to remove the use of $(PYTHON) from the
> clean path is to just `rm -rf build`, but using setup.py seems neater.
>
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
[-- Attachment #2: tools-python-clean.patch --]
[-- Type: text/x-patch, Size: 651 bytes --]
# HG changeset patch
# Parent 33d596f46521ea852e90cf6dbdbf3680d104134c
tools/python: Clean python correctly
Cleaning the python directory should call `$(PYTHON) setup.py clean`
which will clean the build/ subdirectory. Otherwise, subsequent builds
may be short-circuited and a stale build installed.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff -r 33d596f46521 tools/python/Makefile
--- a/tools/python/Makefile
+++ b/tools/python/Makefile
@@ -33,6 +33,7 @@ test:
.PHONY: clean
clean:
+ $(PYTHON) setup.py clean --all
rm -f $(XENPATH)
rm -rf *.pyc *.pyo *.o *.a *~ xen/util/auxbin.pyc
rm -f xen/lowlevel/xl/_pyxl_types.h
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (V2) tools/python: Clean python correctly
2012-08-14 16:54 ` (V2) " Andrew Cooper
@ 2012-08-14 17:34 ` Ian Jackson
2012-08-14 17:41 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2012-08-14 17:34 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Ian Campbell, xen-devel@lists.xen.org
Andrew Cooper writes ("Re: [Xen-devel] (V2) tools/python: Clean python correctly"):
> Attached version 2, because it seems that despite my testing, "python
> setup.py clean" still doesn't actually clean enough.
>
> On 14/08/12 15:10, Andrew Cooper wrote:
> > I discovered this with repeated calls to "make clean; make dist-tools"
> >
> > An alternative, if you wish to remove the use of $(PYTHON) from the
> > clean path is to just `rm -rf build`, but using setup.py seems neater.
Perhaps removing the build directory would be better and faster and
more reliable ?
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: (V2) tools/python: Clean python correctly
2012-08-14 17:34 ` Ian Jackson
@ 2012-08-14 17:41 ` Andrew Cooper
2012-08-14 17:45 ` (V3) " Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2012-08-14 17:41 UTC (permalink / raw)
To: Ian Jackson; +Cc: Ian Campbell, xen-devel@lists.xen.org
On 14/08/12 18:34, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [Xen-devel] (V2) tools/python: Clean python correctly"):
>> Attached version 2, because it seems that despite my testing, "python
>> setup.py clean" still doesn't actually clean enough.
>>
>> On 14/08/12 15:10, Andrew Cooper wrote:
>>> I discovered this with repeated calls to "make clean; make dist-tools"
>>>
>>> An alternative, if you wish to remove the use of $(PYTHON) from the
>>> clean path is to just `rm -rf build`, but using setup.py seems neater.
> Perhaps removing the build directory would be better and faster and
> more reliable ?
>
> Ian.
That would put the code in line with tools/pygrub. Sec while I make a
v3 patch
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: (V3) tools/python: Clean python correctly
2012-08-14 17:41 ` Andrew Cooper
@ 2012-08-14 17:45 ` Andrew Cooper
2012-08-17 13:48 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2012-08-14 17:45 UTC (permalink / raw)
To: Ian Jackson; +Cc: Ian Campbell, xen-devel@lists.xen.org
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On 14/08/12 15:10, Andrew Cooper wrote:
>>>> I discovered this with repeated calls to "make clean; make dist-tools"
>>>>
>>>> An alternative, if you wish to remove the use of $(PYTHON) from the
>>>> clean path is to just `rm -rf build`, but using setup.py seems neater.
>> Perhaps removing the build directory would be better and faster and
>> more reliable ?
>>
>> Ian.
>>
>>
Attached
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
[-- Attachment #2: tools-python-clean.patch --]
[-- Type: text/x-patch, Size: 693 bytes --]
# HG changeset patch
# Parent 33d596f46521ea852e90cf6dbdbf3680d104134c
tools/python: Clean python correctly
Cleaning the python directory should completely remove the build/
directory, otherwise subsequent builds may be short-circuited and a
stale build installed.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff -r 33d596f46521 tools/python/Makefile
--- a/tools/python/Makefile
+++ b/tools/python/Makefile
@@ -34,7 +34,7 @@ test:
.PHONY: clean
clean:
rm -f $(XENPATH)
- rm -rf *.pyc *.pyo *.o *.a *~ xen/util/auxbin.pyc
+ rm -rf build/ *.pyc *.pyo *.o *.a *~ xen/util/auxbin.pyc
rm -f xen/lowlevel/xl/_pyxl_types.h
rm -f xen/lowlevel/xl/_pyxl_types.c
rm -f $(DEPS)
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (V3) tools/python: Clean python correctly
2012-08-14 17:45 ` (V3) " Andrew Cooper
@ 2012-08-17 13:48 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2012-08-17 13:48 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Ian Jackson, xen-devel@lists.xen.org
On Tue, 2012-08-14 at 18:45 +0100, Andrew Cooper wrote:
> tools/python: Clean python correctly
>
> Cleaning the python directory should completely remove the build/
> directory, otherwise subsequent builds may be short-circuited and a
> stale build installed.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
And applied, thanks,
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-17 13:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-14 14:10 tools/python: Clean python correctly Andrew Cooper
2012-08-14 16:54 ` (V2) " Andrew Cooper
2012-08-14 17:34 ` Ian Jackson
2012-08-14 17:41 ` Andrew Cooper
2012-08-14 17:45 ` (V3) " Andrew Cooper
2012-08-17 13:48 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).