From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH v4] hotplug/NetBSD: check type of file to attach from params Date: Fri, 17 Aug 2012 10:25:57 +0200 Message-ID: <502E0015.2090801@amd.com> References: <1344967799-6646-1-git-send-email-roger.pau@citrix.com> <1345191237.30865.76.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345191237.30865.76.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" , Ian Jackson , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On 08/17/12 10:13, Ian Campbell wrote: > On Tue, 2012-08-14 at 19:09 +0100, Roger Pau Monne wrote: >> Changes since v2: > [...] >> * Replace xenstore_write with xenstore-write in error function. > [...] >> error() { >> echo "$@" >&2 >> - xenstore_write $xpath/hotplug-status error >> + xenstore-write $xpath/hotplug-status error >> exit 1 >> } > > Why this seemingly unrelated change? I don't see anything in the > comments on v2 explicitly about it. xenstore-write exists on NetBSD. xenstore_write does not exist. Christoph > > If it is somehow necessary due to this patch then I think that deserves > mention in the changelog proper. > > Is it because xenstore_write is actually specific to the Linux hotplug > scripts? (i.e. this function was just plain broken before). > > While looking into this I noticed that the Linux equivalent to error() > is: > fatal() { > _xenstore_write "$XENBUS_PATH/hotplug-error" "$*" \ > "$XENBUS_PATH/hotplug-status" error > log err "$@" > exit 1 > } > > The write of the log message to hotplus-error seems like something worth > replicating (in a separate patch). > > I also wonder how much of this sort of infrastructure could actually be > shared, but that's for another time. > > Ian. > > -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632