From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] How should QEMU code handle include statements Date: Tue, 21 Aug 2012 13:19:05 +0300 Message-ID: <50336099.3040206@redhat.com> References: <1345419579-25499-1-git-send-email-imammedo@redhat.com> <5031C2A3.3060800@weilnetz.de> <20120820134739.08bf6de4@thinkpad.mammed.net> <50329903.8000608@weilnetz.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50329903.8000608@weilnetz.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefan Weil Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com, anthony.perard@citrix.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com, Igor Mammedov , lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de List-Id: xen-devel@lists.xenproject.org On 08/20/2012 11:07 PM, Stefan Weil wrote: > While I personally prefer (1) and used it for my first contributions, > QEMU introduced qemu-common.h. I had the impression that from then on > QEMU preferred strategy (2). Obviously not everybody shares that > impression. > > Which strategy / rule do we want to use for QEMU code? (1). -- error compiling committee.c: too many arguments to function