From mboxrd@z Thu Jan 1 00:00:00 1970 From: Attilio Rao Subject: Re: [PATCH 2/5] XEN: Remove the base argument from x86_init.paging.pagetable_setup_start PVOPS Date: Tue, 21 Aug 2012 16:49:38 +0100 Message-ID: <5033AE12.20609@citrix.com> References: <1345511646-12427-1-git-send-email-attilio.rao@citrix.com> <1345511646-12427-3-git-send-email-attilio.rao@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: Konrad Rzeszutek Wilk , Ian Campbell , Stefano Stabellini , Ingo Molnar , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 21/08/12 16:41, Thomas Gleixner wrote: > On Tue, 21 Aug 2012, Attilio Rao wrote: > >> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c >> index 1019156..7999cef 100644 >> --- a/arch/x86/mm/init_32.c >> +++ b/arch/x86/mm/init_32.c >> @@ -445,14 +445,17 @@ static inline void permanent_kmaps_init(pgd_t *pgd_base) >> } >> #endif /* CONFIG_HIGHMEM */ >> >> -void __init native_pagetable_setup_start(pgd_t *base) >> +void __init native_pagetable_setup_start(void) >> { >> unsigned long pfn, va; >> + pgd_t *base; >> pgd_t *pgd; >> > pgd_t *pgd, *base = swapper_pg_dir; > > Please. No need to add 5 lines just for this. > > I honestly thought it was cleaner -- what is exactly your preferred choice? Just use swapper_pg_dir directly in the 2 places needing it? Attilio