xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* Re: Xen4.2 S3 regression?
@ 2012-08-23 18:54 Andrew Cooper
  2012-08-23 19:06 ` Ben Guthro
  0 siblings, 1 reply; 132+ messages in thread
From: Andrew Cooper @ 2012-08-23 18:54 UTC (permalink / raw)
  To: Ben Guthro
  Cc: Jan Beulich, Konrad Rzeszutek Wilk, John Baboval, Thomas Goetz,
	xen-devel@lists.xen.org


[-- Attachment #1.1: Type: text/plain, Size: 2410 bytes --]

> On 23/08/12 19:03, Ben Guthro wrote:
>> I did some more bisecting here, and I came up with another changeset
>> that seems to be problematic, Re: IRQs
>>
>> After bisecting the problem discussed earlier in this thread to the
>> changeset below,
>> http://xenbits.xen.org/hg/xen-unstable.hg/rev/0695a5cdcb42
>>
>>
>> I worked past that issue by the following hack:
>>
>> --- a/xen/common/event_channel.c
>> +++ b/xen/common/event_channel.c
>> @@ -1103,7 +1103,7 @@ void evtchn_destroy_final(struct domain *d)
>>  void evtchn_move_pirqs(struct vcpu *v)
>>  {
>>      struct domain *d = v->domain;
>> -    const cpumask_t *mask = cpumask_of(v->processor);
>> +    //const cpumask_t *mask = cpumask_of(v->processor);
>>      unsigned int port;
>>      struct evtchn *chn;
>>
>> @@ -1111,7 +1111,9 @@ void evtchn_move_pirqs(struct vcpu *v)
>>      for ( port = v->pirq_evtchn_head; port; port = chn->u.pirq.next_port )
>>      {
>>          chn = evtchn_from_port(d, port);
>> +#if 0
>>          pirq_set_affinity(d, chn->u.pirq.irq, mask);
>> +#endif
>>      }
>>      spin_unlock(&d->event_lock);
>>  }
>>
>>
>> This seemed to work for this rather old changeset, but it was not
>> sufficient to fix it against the 4.1, or unstable trees.
>>
>> I further bisected, in combination with this hack, and found the
>> following changeset to also be problematic:
>>
>> http://xenbits.xen.org/hg/xen-unstable.hg/rev/c2cb776a5365
>>
>>
>> That is, before this change I could resume reliably (with the hack
>> above) - and after I could not.
>> This was surprising to me, as this change also looks rather innocuous.
> And by the looks of that changeset, the logic in fixup_irqs() in irq.c
> was changed.
>
> Jan: The commit message says "simplify operations [in] a few cases". 
> Was the change in fixup_irqs() deliberate?
>
> ~Andrew

Ben: Could you test the attached patch?  It is for unstable and undoes
the logical change to fixup_irqs()

~Andrew

>
>> Naturally, backing out this change seems to be non-trivial against the
>> tip, since so much around it has changed.
>>
> -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44
> (0)1223 225 900, http://www.citrix.com
> _______________________________________________ Xen-devel mailing list
> Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com


[-- Attachment #1.2: Type: text/html, Size: 3829 bytes --]

[-- Attachment #2: s3-revert-fixup_irqs.patch --]
[-- Type: text/x-patch, Size: 515 bytes --]

# HG changeset patch
# Parent b02ac80ff6899e98b4089842843104fd8572a7cd

diff -r b02ac80ff689 xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -2151,7 +2151,7 @@ void fixup_irqs(void)
         spin_lock(&desc->lock);
 
         cpumask_copy(&affinity, desc->affinity);
-        if ( !desc->action || cpumask_subset(&affinity, &cpu_online_map) )
+        if ( !desc->action || cpumask_equal(&affinity, &cpu_online_map) )
         {
             spin_unlock(&desc->lock);
             continue;

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 132+ messages in thread
* Xen4.2 S3 regression?
@ 2012-08-07 15:04 Ben Guthro
  2012-08-07 16:21 ` Ben Guthro
  0 siblings, 1 reply; 132+ messages in thread
From: Ben Guthro @ 2012-08-07 15:04 UTC (permalink / raw)
  To: xen-devel

I have been doing some experiments in upgrading the Xen version in a
future version of XenClient Enterprise, and I've been running into a
regression that I'm wondering if anyone else has seen.

dom0 suspend/resume (S3) does not seem to be working for me.

In swapping out components of the system, the common failure seems to
be when I use Xen-4.2 (upgraded from Xen-4.0.3)

The first suspend seems to mostly work...but subsequent ones always
resume improperly.
By "improperly" - I see I/O failures, and stalls of many processes.

Below is a log excerpt of 2 S3 attempts.


Has anyone else seen these failures?

- Ben


(XEN) Preparing system for ACPI S3 state.
(XEN) Disabling non-boot CPUs ...
(XEN) Breaking vcpu affinity for domain 0 vcpu 1
(XEN) Breaking vcpu affinity for domain 0 vcpu 2
(XEN) Breaking vcpu affinity for domain 0 vcpu 3
(XEN) Entering ACPI S3 state.
(XEN) mce_intel.c:1239: MCA Capability: BCAST 1 SER 0 CMCI 1 firstbank
0 extended MCE MSR 0
(XEN) CPU0 CMCI LVT vector (0xf1) already installed
(XEN) Finishing wakeup from ACPI S3 state.
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) Enabling non-boot CPUs  ...
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
[   36.440696] [drm:pch_irq_handler] *ERROR* PCH poison interrupt
(XEN) Preparing system for ACPI S3 state.
(XEN) Disabling non-boot CPUs ...
(XEN) Entering ACPI S3 state.
(XEN) mce_intel.c:1239: MCA Capability: BCAST 1 SER 0 CMCI 1 firstbank
0 extended MCE MSR 0
(XEN) CPU0 CMCI LVT vector (0xf1) already installed
(XEN) Finishing wakeup from ACPI S3 state.
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) Enabling non-boot CPUs  ...
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
(XEN) microcode: collect_cpu_info : sig=0x306a4, pf=0x2, rev=0x7
[   65.893235] [drm:pch_irq_handler] *ERROR* PCH poison interrupt
[   66.508829] ata3.00: revalidation failed (errno=-5)
[   66.508861] ata1.00: revalidation failed (errno=-5)
[   76.858815] ata3.00: revalidation failed (errno=-5)
[   76.898807] ata1.00: revalidation failed (errno=-5)
[  107.208817] ata3.00: revalidation failed (errno=-5)
[  107.288807] ata1.00: revalidation failed (errno=-5)
[  107.718866] pm_op(): scsi_bus_resume_common+0x0/0x60 returns 262144
[  107.718877] PM: Device 0:0:0:0 failed to resume async: error 262144
[  107.718913] end_request: I/O error, dev sda, sector 35193296
[  107.718919] Buffer I/O error on device dm-5, logical block 7690
[  107.718947] end_request: I/O error, dev sda, sector 35657184
[  107.718965] end_request: I/O error, dev sda, sector 246202760
[  107.718968] Buffer I/O error on device dm-6, logical block 26252801
[  107.718995] end_request: I/O error, dev sda, sector 254548368
[  107.719009] Aborting journal on device dm-6-8.
[  107.719021] end_request: I/O error, dev sda, sector 35164192
[  107.719023] Buffer I/O error on device dm-5, logical block 4052
[  107.719063] Aborting journal on device dm-5-8.
[  107.719085] end_request: I/O error, dev sda, sector 254546304
[  107.719097] Buffer I/O error on device dm-6, logical block 27295744
[  107.719129] JBD2: I/O error detected when updating journal
superblock for dm-6-8.
[  107.719141] end_request: I/O error, dev sda, sector 35656064
[  107.719146] Buffer I/O error on device dm-5, logical block 65536
[  107.719168] JBD2: I/O error detected when updating journal
superblock for dm-5-8.
[  107.870082] end_request: I/O error, dev sda, sector 35131776
[  107.875825] Buffer I/O error on device dm-5, logical block 0
[  107.881805] end_request: I/O error, dev sda, sector 35131776
[  107.887637] Buffer I/O error on device dm-5, logical block 0
[  107.893573] EXT4-fs error (device dm-5): ext4_journal_start_sb:327:
[  107.893579] EXT4-fs (dm-5): I/O error while writing superblock
[  107.893582] EXT4-fs error (device dm-5): ext4_journal_start_sb:327:
Detected aborted journal
[  107.893584] EXT4-fs (dm-5): Remounting filesystem read-only
[  107.893617] end_request: I/O error, dev sda, sector 35131776
[  107.893620] Buffer I/O error on device dm-5, logical block 0
[  107.893749] end_request: I/O error, dev sda, sector 36180352
[  107.893752] Buffer I/O error on device dm-6, logical block 0
[  107.893762] EXT4-fs error (device dm-6): ext4_journal_start_sb:327:
Detected aborted journal
[  107.893765] EXT4-fs (dm-6): Remounting filesystem read-only
[  107.893766] EXT4-fs (dm-6): previous I/O error to superblock detected
[  107.893784] end_request: I/O error, dev sda, sector 36180352
[  107.893787] Buffer I/O error on device dm-6, logical block 0
[  107.894467] EXT4-fs error (device dm-5): ext4_journal_start_sb:327:
Detected aborted journal
[  108.669763] end_request: I/O error, dev sda, sector 25957784
[  108.675555] Aborting journal on device dm-3-8.
[  108.680246] end_request: I/O error, dev sda, sector 25956736
[  108.686099] JBD2: I/O error detected when updating journal
superblock for dm-3-8.
[  108.693908] journal commit I/O error
[  108.755829] end_request: I/O error, dev sda, sector 17305984
[  108.761600] EXT4-fs error (device dm-3): ext4_journal_start_sb:327:
Detected aborted journal
[  108.770340] EXT4-fs (dm-3): Remounting filesystem read-only
[  108.776159] EXT4-fs (dm-3): previous I/O error to superblock detected
[  108.782904] end_request: I/O error, dev sda, sector 17305984
[  109.660011] end_request: I/O error, dev sda, sector 358788
[  109.665572] Buffer I/O error on device dm-1, logical block 46082
[  109.682479] end_request: I/O error, dev sda, sector 18832256
[  109.688246] end_request: I/O error, dev sda, sector 18832256
[  109.709559] end_request: I/O error, dev sda, sector 357762
[  109.715120] Buffer I/O error on device dm-1, logical block 45569
[  109.721506] end_request: I/O error, dev sda, sector 358790
[  109.727114] Buffer I/O error on device dm-1, logical block 46083
[  109.743714] end_request: I/O error, dev sda, sector 18832256
[  109.755555] end_request: I/O error, dev sda, sector 18832256
[  109.886187] end_request: I/O error, dev sda, sector 357764
[  109.891756] Buffer I/O error on device dm-1, logical block 45570
[  109.908344] end_request: I/O error, dev sda, sector 18832256
[  109.928369] end_request: I/O error, dev sda, sector 349574
[  109.933938] Buffer I/O error on device dm-1, logical block 41475
[  109.950336] end_request: I/O error, dev sda, sector 18832256
[  115.378875] end_request: I/O error, dev sda, sector 365000
[  115.384445] Aborting journal on device dm-1-8.
[  115.389120] end_request: I/O error, dev sda, sector 364930
[  115.394798] Buffer I/O error on device dm-1, logical block 49153
[  115.401101] JBD2: I/O error detected when updating journal
superblock for dm-1-8.
[  207.207426] end_request: I/O error, dev sda, sector 246192376
[  207.213313] end_request: I/O error, dev sda, sector 246192376
[  207.903181] end_request: I/O error, dev sda, sector 246192376
[  209.234399] end_request: I/O error, dev sda, sector 18518400
[  209.240221] end_request: I/O error, dev sda, sector 18518400

^ permalink raw reply	[flat|nested] 132+ messages in thread

end of thread, other threads:[~2012-09-27 15:32 UTC | newest]

Thread overview: 132+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-23 18:54 Xen4.2 S3 regression? Andrew Cooper
2012-08-23 19:06 ` Ben Guthro
2012-08-23 19:26   ` Ben Guthro
2012-08-23 19:38   ` Andrew Cooper
2012-08-23 20:38     ` Ben Guthro
2012-08-24 15:10       ` Ben Guthro
2012-08-24 22:16         ` Jan Beulich
     [not found]           ` <CAOvdn6U1touhawCb2GvgVQZqxhWn9CRw6-wkqdxk=uOTq015OA@mail.gmail.com>
2012-09-06  9:24             ` Jan Beulich
  -- strict thread matches above, loose matches on Subject: below --
2012-08-07 15:04 Ben Guthro
2012-08-07 16:21 ` Ben Guthro
2012-08-07 16:33   ` Konrad Rzeszutek Wilk
2012-08-07 16:48     ` Ben Guthro
2012-08-07 20:14       ` Ben Guthro
2012-08-08  8:35         ` Jan Beulich
2012-08-08 10:39           ` Ben Guthro
2012-08-09 15:21             ` Ben Guthro
2012-08-09 15:37               ` Jan Beulich
2012-08-09 15:46                 ` Ben Guthro
2012-08-09 15:51                   ` Jan Beulich
2012-08-09 16:09                     ` Ben Guthro
2012-08-10  6:50                       ` Jan Beulich
2012-08-10 19:15                         ` Ben Guthro
2012-08-14 17:31                           ` Ben Guthro
2012-08-15  8:11                             ` Jan Beulich
2012-08-15 10:32                               ` Ben Guthro
2012-08-15 12:32                                 ` Ben Guthro
2012-08-15 12:58                                   ` Jan Beulich
2012-08-15 13:11                                     ` Ben Guthro
2012-08-15 14:50                                       ` Jan Beulich
2012-08-15 14:58                                         ` Ben Guthro
2012-08-15 15:00                                           ` Andrew Cooper
2012-08-15 15:06                                           ` Jan Beulich
2012-08-15 15:16                                             ` Ben Guthro
2012-08-16  8:31                                       ` Jan Beulich
2012-08-16 10:37                                         ` Ben Guthro
2012-08-16 11:07                                           ` Jan Beulich
2012-08-16 11:56                                             ` Ben Guthro
2012-08-17 10:22                                               ` Ben Guthro
2012-08-17 10:40                                                 ` Jan Beulich
2012-08-23 18:03                                                   ` Ben Guthro
2012-08-23 18:37                                                     ` Andrew Cooper
2012-08-24 22:11                                                       ` Jan Beulich
2012-08-24 22:55                                                     ` Jan Beulich
2012-08-25  0:48                                                       ` Ben Guthro
2012-09-03  9:31                                               ` Jan Beulich
2012-09-04 12:27                                                 ` Ben Guthro
2012-09-04 12:49                                                   ` Ben Guthro
2012-09-04 14:26                                                     ` Jan Beulich
2012-09-04 14:28                                                       ` Ben Guthro
2012-09-04 14:36                                                         ` Konrad Rzeszutek Wilk
2012-09-04 15:02                                                         ` Jan Beulich
2012-09-06 10:22                                                   ` Jan Beulich
2012-09-06 11:48                                                     ` Ben Guthro
2012-09-06 11:51                                                       ` Ben Guthro
2012-09-06 13:05                                                       ` Konrad Rzeszutek Wilk
2012-09-06 13:27                                                         ` Ben Guthro
2012-09-06 13:36                                                           ` Ben Guthro
2012-09-06 16:42                                                       ` Ben Guthro
2012-09-07  8:38                                                         ` Jan Beulich
2012-09-07 10:37                                                           ` Ben Guthro
2012-09-07 11:15                                                             ` Jan Beulich
2012-09-07 11:51                                                               ` Ben Guthro
2012-09-07 12:18                                                                 ` Jan Beulich
2012-09-07 16:06                                                                   ` Ben Guthro
2012-09-19 21:07                                                                     ` Ben Guthro
2012-09-20  6:13                                                                       ` Keir Fraser
2012-09-20  6:24                                                                         ` Keir Fraser
2012-09-20  8:03                                                                         ` Jan Beulich
2012-09-20  8:14                                                                           ` Keir Fraser
2012-09-20 12:56                                                                           ` Ben Guthro
2012-09-20 13:07                                                                             ` Keir Fraser
2012-09-20 20:30                                                                             ` Ben Guthro
2012-09-21  6:34                                                                               ` Keir Fraser
2012-09-21  6:47                                                                               ` Jan Beulich
2012-09-21 18:20                                                                                 ` Ben Guthro
2012-09-21 18:42                                                                                   ` Keir Fraser
2012-09-24 11:22                                                                                     ` Jan Beulich
2012-09-24 11:25                                                                                       ` Ben Guthro
2012-09-24 11:45                                                                                         ` Jan Beulich
2012-09-24 11:54                                                                                           ` Ben Guthro
2012-09-24 12:05                                                                                             ` Jan Beulich
2012-09-24 12:24                                                                                               ` Ben Guthro
2012-09-24 12:32                                                                                                 ` Jan Beulich
     [not found]                                                                                                   ` <CAOvdn6UMHmPWqedYE9GQQMDaM4oiHLDSn9ZzSgJjGf89g1DgTw@mail.gmail.com>
     [not found]                                                                                                     ` <50607D70020000780009D5C3@nat28.tlf.novell.com>
     [not found]                                                                                                       ` <CAOvdn6XL9ebp2oUV0XEXk_WdU3-=YAj+xfz6AMLDBpVThH3Xvw@mail.gmail.com>
2012-09-24 14:10                                                                                                         ` Jan Beulich
2012-09-24 14:16                                                                                                           ` Ben Guthro
2012-09-24 14:28                                                                                                             ` Jan Beulich
2012-09-24 19:02                                                                                                               ` Ben Guthro
2012-09-24 20:30                                                                                                                 ` Keir Fraser
2012-09-24 20:46                                                                                                                   ` Ben Guthro
2012-09-24 21:12                                                                                                                     ` Ben Guthro
2012-09-25  7:00                                                                                                                       ` Jan Beulich
2012-09-25 11:56                                                                                                                         ` Ben Guthro
2012-09-25 14:22                                                                                                                           ` Ben Guthro
2012-09-25 14:53                                                                                                                             ` Keir Fraser
2012-09-25 15:10                                                                                                                             ` Jan Beulich
2012-09-25 15:45                                                                                                                               ` Ben Guthro
2012-09-25 15:52                                                                                                                                 ` Keir Fraser
2012-09-26 11:49                                                                                                                                 ` Jan Beulich
2012-09-26 10:43                                                                                                                           ` Jan Beulich
2012-09-26 10:47                                                                                                                             ` Ben Guthro
2012-09-26 18:21                                                                                                                             ` Ben Guthro
2012-09-27  7:38                                                                                                                               ` Jan Beulich
2012-09-27  7:46                                                                                                                                 ` Keir Fraser
2012-09-27 12:12                                                                                                                                 ` Ben Guthro
2012-09-27 13:41                                                                                                                                   ` Jan Beulich
2012-09-27 15:25                                                                                                                                   ` Jan Beulich
2012-09-27 15:32                                                                                                                                     ` Ben Guthro
2012-09-24 14:32                                                                                                             ` Keir Fraser
2012-09-24 12:22                                                                                             ` Pasi Kärkkäinen
2012-09-24 12:27                                                                                               ` Ben Guthro
2012-09-24 12:37                                                                                                 ` Javier Marcet
2012-09-24 14:04                                                                                                   ` Konrad Rzeszutek Wilk
2012-09-24 15:08                                                                                                     ` Javier Marcet
2012-09-24 21:36                                                                                                     ` Javier Marcet
2012-09-25 14:06                                                                                                       ` Konrad Rzeszutek Wilk
2012-09-25 14:47                                                                                                         ` Javier Marcet
2012-09-25 15:21                                                                                                           ` Jan Beulich
2012-09-25 15:23                                                                                                             ` Javier Marcet
2012-09-25 19:55                                                                                                             ` Javier Marcet
2012-09-25 19:57                                                                                                               ` Ben Guthro
2012-09-25 20:08                                                                                                                 ` Javier Marcet
2012-09-26  7:17                                                                                                               ` Jan Beulich
2012-09-26  7:59                                                                                                                 ` Javier Marcet
2012-09-26 12:43                                                                                                                   ` Konrad Rzeszutek Wilk
2012-09-26 14:14                                                                                                                     ` Javier Marcet
2012-09-26 14:26                                                                                                                       ` Ben Guthro
2012-09-26 14:40                                                                                                                         ` Javier Marcet
2012-09-26  8:05                                                                                                                 ` Javier Marcet
2012-09-24 12:37                                                                                                 ` Jan Beulich
2012-09-24 14:02                                                                                             ` Konrad Rzeszutek Wilk
2012-09-20  7:17                                                                       ` Jan Beulich
     [not found]                           ` <CAAnFQG-u1VUDgn11ZW0=UaYC4MvUtxxq8ZjjUOrNpXTSUWP41Q@mail.gmail.com>
     [not found]                             ` <CAOvdn6VuD_5Mhd9wvOskfZWfCBjr2nT5LppDxyY5S-5LhGhSvA@mail.gmail.com>
     [not found]                               ` <CAAnFQG_hMNvwM9Z3XPGR590=Gifos-kOftqjLFUX4YFW6tTTgg@mail.gmail.com>
     [not found]                                 ` <CAOvdn6UzdzO_sM6f9coN2udQ6eUC5=Sty-NgC7+yf3XMawF-0A@mail.gmail.com>
2012-09-04 15:31                                   ` Javier Marcet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).