From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: (v2) docs/command line: Clarify the behavior with invalid input.
Date: Fri, 31 Aug 2012 17:49:31 +0100 [thread overview]
Message-ID: <5040EB1B.80004@citrix.com> (raw)
In-Reply-To: <5040F61A0200007800097E86@nat28.tlf.novell.com>
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
On 31/08/12 16:36, Jan Beulich wrote:
>>>> On 31.08.12 at 16:55, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> I don't think we should specifically document the behavior for
> unexpected value; instead, the behavior should simply be
> "undefined".
>
> Jan
>
Yes ok. v2 attached.
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
[-- Attachment #2: docs-cmdline.patch --]
[-- Type: text/x-patch, Size: 1702 bytes --]
# HG changeset patch
# Parent 993922337bc1ceaac1054c31ba683af74e737cc1
docs/command line: Clarify the behavior with invalid input.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
--
v2: State that invalid input is undefined, rather than describing the
current behaviour.
diff -r 993922337bc1 docs/misc/xen-command-line.markdown
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -11,7 +11,8 @@ Hypervisor.
## Types of parameter
Most parameters take the form `option=value`. Different options on
-the command line should be space delimited.
+the command line should be space delimited. All options are case
+sensitive, as are all values unless explicitly noted.
### Boolean (`<boolean>`)
@@ -35,6 +36,9 @@ Disable x2apic support (if present)
Enable synchronous console mode
> `sync_console`
+Explicitly specifying any value other than those listed above is
+undefined, as is stacking a `no-` prefix with an explicit value.
+
### Integer (`<integer>`)
An integer parameter will default to decimal and may be prefixed with
@@ -42,6 +46,9 @@ a `-` for negative numbers. Alternative
used by prefixing the number with `0x`, or an octal number may be used
if a leading `0` is present.
+Providing a string which does not validly convert to an integer is
+undefined.
+
### Size (`<size>`)
A size parameter may be any integer, with a size suffix
@@ -51,7 +58,8 @@ A size parameter may be any integer, wit
* `K` or `k`: Kilo (2^10)
* `B` or `b`: Bytes
-Without a size suffix, the default will be kilo.
+Without a size suffix, the default will be kilo. Providing a suffix
+other than those listed above is undefined.
### String
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-08-31 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 14:55 docs/command line: Clarify the behavior with invalid input Andrew Cooper
2012-08-31 15:06 ` Ian Campbell
2012-08-31 15:36 ` Jan Beulich
2012-08-31 16:49 ` Andrew Cooper [this message]
2012-09-03 6:55 ` (v2) " Jan Beulich
2012-09-03 10:23 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5040EB1B.80004@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).