From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] kexec/noreboot: Don't kexec_crash() if noreboot has been requested. Date: Fri, 7 Sep 2012 16:42:19 +0100 Message-ID: <504A15DB.1010706@citrix.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Keir Fraser Cc: Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 07/09/12 16:03, Keir Fraser wrote: > On 07/09/2012 14:16, "Jan Beulich" wrote: > >>>>> On 07.09.12 at 15:05, Andrew Cooper wrote: >>> This issue came up when debugging pcpu linked list corruption (patches >>> for that issue to follow). >> Hmm, that's a matter of taste of course. Nor is running kdump >> really a (direct) reboot action. Both ways have their reasoning >> imo, so I'm not sure whether keeping things as is or applying the >> patch is the better thing. > I note though that kexec_crash() should be stubbed out in the header file > when !CONFIG_KEXEC, rather than ifdef at the caller. By the by. > > -- Keir Agreed - I will put it on my todo list to fix. (I think its elsewhere in the codebase as well) ~Andrew > >> Jan >> > -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com