From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH V2 7/9] libxl_qmp: Introduce
	libxl__qmp_set_global_dirty_log.
Date: Tue, 25 Sep 2012 15:51:08 +0100
Message-ID: <5061C4DC.4010900@citrix.com>
References: <1347906148-9606-1-git-send-email-anthony.perard@citrix.com>
	<1347906148-9606-8-git-send-email-anthony.perard@citrix.com>
	<1348564001.3452.127.camel@zakaz.uk.xensource.com>
	<1348564200.3452.128.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1348564200.3452.128.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen Devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 09/25/2012 10:10 AM, Ian Campbell wrote:
> On Tue, 2012-09-25 at 10:06 +0100, Ian Campbell wrote:
>>> +    rc = qmp_run_command(gc, domid, "xen-set-global-dirty-log", args,
>>> +                         NULL, NULL);
> 
> For got to ask: Is this new function upstream and in our branch already?

No, the patches haven't been accepted yet.

> I suppose there is no ordering constraint since we fail now, and if we
> take this patch we'll just fail more explicitly with an ENOSYS type
> error unless/until the qemu half is in place.

Yep, patches can be apply in any order. If QEMU does not know the
command, then it will return an error, and it will be relayed by libxl.


-- 
Anthony PERARD