xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] Upgrade vtpmd to berlios version 0.7.4
Date: Wed, 26 Sep 2012 16:09:53 +0100	[thread overview]
Message-ID: <50631AC1.1040000@eu.citrix.com> (raw)
In-Reply-To: <506313BD.7020600@jhuapl.edu>

On 26/09/12 15:39, Matthew Fioravante wrote:
> The last piece of this puzzle that I haven't figured out is the linux
> tpm frontend driver. Its not in the main linux tree. Its from the old
> 2006 vtpm code but it still works. I believe it shipped with the old xen
> 2.6.18 kernel but now I don't know whats happened to it. I still have a
> copy we have been porting to newer kernels internally.
>
> Should we try to get it in mainline linux? Or maybe provide it in the
> xen tree as an externally compilable kernel module?
>
> There also exists a linux tpm backend driver, but if were only going to
> support the domain model that is no longer needed and can go away.
We should absolutely get it into mainline Linux.  I presume it's mainly 
the front/back code, which would live in the xen/ tree, and then hooks 
to make it work with /dev/tpm?  It seems like that should be fairly 
straightforward to get upstream.

Re the backend driver: obviously you're going to be the one doing the 
work, so the final call will be up to you.  But it seems to me that if 
it's not too difficult (and from the docs I looked at, it seemed like 
not much more than a dumb pipe?), I think you might as well port it.  
That would make it easy to run vtpm and vtpmmgr in Linux stubdoms 
instead of a mini-os stubdoms, should it ever becomes necessary to do so 
(for instance, if the vtpm code ever requires more functionality than 
the mini-os libc has).

To upstream, I think the SOP is to rebase to the most recently released 
Linux kernel (3.6 now I think), and cross-post the patches to xen-devel 
and linux-kernel, CC'ing the Xen maintainer, Konrad Wilk 
<konrad.wilk@oracle.com>, and probably the TPM maintianer as well.  
(Correct me if I'm wrong, Konrad!)

  -George

  reply	other threads:[~2012-09-26 15:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17 17:52 [PATCH] Upgrade vtpmd to berlios version 0.7.4 Matthew Fioravante
2012-09-18  7:38 ` Ian Campbell
2012-09-18 17:33   ` Matthew Fioravante
2012-09-25  9:53     ` Ian Campbell
2012-09-25 15:50       ` Matthew Fioravante
2012-09-26 11:46         ` George Dunlap
2012-09-26 14:39           ` Matthew Fioravante
2012-09-26 15:09             ` George Dunlap [this message]
2012-09-26 15:21             ` Ian Campbell
2012-09-26 15:58               ` Matthew Fioravante

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50631AC1.1040000@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=matthew.fioravante@jhuapl.edu \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).