From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 1/2] libxl_json: Use libxl alloc function
Date: Mon, 1 Oct 2012 15:04:05 +0100
Message-ID: <5069A2D5.9010205@citrix.com>
References: <1348666294-18182-1-git-send-email-anthony.perard@citrix.com>
	<1348666294-18182-2-git-send-email-anthony.perard@citrix.com>
	<20581.56505.946303.990641@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20581.56505.946303.990641@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Xen Devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 09/28/2012 06:22 PM, Ian Jackson wrote:
> Anthony PERARD writes ("[Xen-devel] [PATCH 1/2] libxl_json: Use libxl alloc function"):
>> This patch makes use of the libxl allocation API and removes the check for
>> allocation failure.
>>
>> This patch also assume that flexarray does not need to be freed as it will be
>> gc'd in the next patch.
> 
> Is this really the right way to structure this series ?  It seems that
> after applying only the first, the code has a memory leak.

Yes, there is a memory leak if only this patch is applied. I'll find a
better way to structure this patch series.

-- 
Anthony PERARD