From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/2] libxl: Have flexarray using the GC
Date: Mon, 1 Oct 2012 15:23:43 +0100	[thread overview]
Message-ID: <5069A76F.8040901@citrix.com> (raw)
In-Reply-To: <20585.42493.151224.551455@mariner.uk.xensource.com>
On 10/01/2012 03:17 PM, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [Xen-devel] [PATCH 2/2] libxl: Have flexarray using the GC"):
>> > On 09/28/2012 06:27 PM, Ian Jackson wrote:
>>> > > If gc is NOGC then this does the wrong thing.  Callers should be able
>>> > > to specify NOGC for a flexarray which they want to survive across
>>> > > multiple calls into libxl.
>> > 
>> > I'm not sure I see your point here.  If a something needs a NOGC'ed
>> > flexarray, then flexarray_make(NOGC, x, x) will give this.
> So then you put the flexarray in some long-term data structure, which
> survives the call to libxl and therefore the gc.  Is it safe for
> NOGC's gc*, derived from the now-destroyed actual gc, to be embedded
> in the flexarray and reused later in a different libxl call with a
> different gc (but the same ctx) ?
Ah, I now see the issue, a pointer that lead nowhere :S.
Thanks,
-- 
Anthony PERARD
     prev parent reply	other threads:[~2012-10-01 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 13:31 [PATCH 0/2] Cleanup: flexarray taking gc Anthony PERARD
2012-09-26 13:31 ` [PATCH 1/2] libxl_json: Use libxl alloc function Anthony PERARD
2012-09-28 17:22   ` Ian Jackson
2012-10-01 14:04     ` Anthony PERARD
2012-09-26 13:31 ` [PATCH 2/2] libxl: Have flexarray using the GC Anthony PERARD
2012-09-28 17:27   ` Ian Jackson
2012-10-01 14:15     ` Anthony PERARD
2012-10-01 14:17       ` Ian Jackson
2012-10-01 14:23         ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=5069A76F.8040901@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).