From: "H. Peter Anvin" <hpa@zytor.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
lenb@kernel.org, linux-acpi@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 2/4] xen/lowlevel: Implement pvop call for load_idt (sidt).
Date: Wed, 17 Oct 2012 16:51:17 -0700 [thread overview]
Message-ID: <507F4475.80705@zytor.com> (raw)
In-Reply-To: <1350481786-4969-3-git-send-email-konrad.wilk@oracle.com>
On 10/17/2012 06:49 AM, Konrad Rzeszutek Wilk wrote:
> In the past it used to point to 'sidt' (native_store_idt) operation
> which is a non-privileged operation. This resulted in the
> 'struct desc_ptr' value containing the address of Xen's IDT table,
> instead of the IDT table that Linux thinks its using. The end result
> is that doing:
>
> store_idt(&desc);
> load_idt(&desc);
>
> would blow up b/c xen_load_idt would try to parse the IDT contents
> (desc) and de-reference a virtual address that is outside Linux's
> __va (it is in Xen's virtual address).
>
> With this patch we are providing the last written IDT address.
>
OK... this seems like another excellent set of pvops calls that should
be nukable to Kingdom Come. There is no reason, ever, to read the IDT
and GDT from the kernel... the kernel already knows what they should be!
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-10-17 23:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 13:49 [RFC] ACPI S3 and Xen (suprisingly small\!) Konrad Rzeszutek Wilk
2012-10-17 13:49 ` [PATCH 1/4] x86/wakeup/sleep: Check whether the TSS GDT descriptor is empty before using it Konrad Rzeszutek Wilk
2012-10-18 0:03 ` H. Peter Anvin
2012-10-18 14:47 ` Konrad Rzeszutek Wilk
2012-10-18 15:01 ` H. Peter Anvin
2013-01-17 14:41 ` Konrad Rzeszutek Wilk
2012-10-17 13:49 ` [PATCH 2/4] xen/lowlevel: Implement pvop call for load_idt (sidt) Konrad Rzeszutek Wilk
2012-10-17 23:51 ` H. Peter Anvin [this message]
2012-10-18 14:45 ` Konrad Rzeszutek Wilk
2012-10-18 15:02 ` H. Peter Anvin
2013-01-17 14:36 ` Konrad Rzeszutek Wilk
2012-10-17 13:49 ` [PATCH 3/4] xen/lowlevel: Implement pvop call for store_gdt (gidt) Konrad Rzeszutek Wilk
2012-10-17 13:49 ` [PATCH 4/4] xen/acpi: Prep saved_context cr3 values Konrad Rzeszutek Wilk
2013-01-17 14:48 ` Konrad Rzeszutek Wilk
2012-10-17 16:03 ` [RFC] ACPI S3 and Xen (suprisingly small\!) H. Peter Anvin
2012-10-17 16:10 ` Is: axe read_tscp pvops call. Was: " Konrad Rzeszutek Wilk
2012-10-17 16:39 ` Konrad Rzeszutek Wilk
2012-10-17 16:54 ` H. Peter Anvin
2012-10-17 16:50 ` H. Peter Anvin
2012-10-17 16:54 ` Konrad Rzeszutek Wilk
2012-10-17 17:35 ` H. Peter Anvin
2012-10-18 15:22 ` [Xen-devel] " Dan Magenheimer
2012-10-18 15:28 ` H. Peter Anvin
2012-10-18 15:56 ` Dan Magenheimer
2012-10-18 16:17 ` Borislav Petkov
2012-10-18 16:44 ` Stefano Stabellini
2012-10-18 17:04 ` H. Peter Anvin
2012-10-18 16:37 ` H. Peter Anvin
2012-10-19 15:48 ` Is: Xen architecture document. Was: " Konrad Rzeszutek Wilk
2012-10-19 17:45 ` H. Peter Anvin
2012-10-18 16:31 ` David Vrabel
2012-10-18 17:42 ` Konrad Rzeszutek Wilk
2012-10-18 18:02 ` David Vrabel
2012-10-17 17:46 ` Ben Guthro
2012-10-17 17:43 ` Konrad Rzeszutek Wilk
2012-10-17 18:00 ` Ben Guthro
2012-10-19 18:49 ` Konrad Rzeszutek Wilk
2012-10-20 1:23 ` Ben Guthro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507F4475.80705@zytor.com \
--to=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).