From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 5 of 6] xen: sched_sedf: beautify statisics
	in SEDF
Date: Tue, 23 Oct 2012 17:26:44 +0100
Message-ID: <5086C544.4070607@eu.citrix.com>
References: <patchbomb.1350916833@Solace>
	<27c4c065efe366a5d761.1350916838@Solace>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <27c4c065efe366a5d761.1350916838@Solace>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Paul Durrant <Paul.Durrant@citrix.com>, "Keir (Xen.org)" <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 22/10/12 15:40, Dario Faggioli wrote:
> By gathering all the related fields in a struct (as it is being done
> in credit) and using the macros we now have available. No functional
> changes involved.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

I'm OK with this as it is, but...

>   #ifdef SEDF_STATS
> -    if ( EDOM_INFO(d)->block_time_tot != 0 )
> -        printk(" pen=%"PRIu64"%%", (EDOM_INFO(d)->penalty_time_tot * 100) /
> -               EDOM_INFO(d)->block_time_tot);
> -    if ( EDOM_INFO(d)->block_tot != 0 )
> +    if ( EDOM_INFO(d)->stats.block_time_tot != 0 )
> +        printk(" pen=%"PRIu64"%%", (EDOM_INFO(d)->stats.penalty_time_tot * 100) /
> +               EDOM_INFO(d)->stats.block_time_tot);
> +    if ( EDOM_INFO(d)->stats.block_tot != 0 )
>           printk("\n   blks=%u sh=%u (%u%%) (shc=%u (%u%%) shex=%i "\
>                  "shexsl=%i) l=%u (%u%%) avg: b=%"PRIu64" p=%"PRIu64"",
> -               EDOM_INFO(d)->block_tot, EDOM_INFO(d)->short_block_tot,
> -               (EDOM_INFO(d)->short_block_tot * 100)
> -               / EDOM_INFO(d)->block_tot, EDOM_INFO(d)->short_cont,
> -               (EDOM_INFO(d)->short_cont * 100) / EDOM_INFO(d)->block_tot,
> -               EDOM_INFO(d)->pen_extra_blocks,
> -               EDOM_INFO(d)->pen_extra_slices,
> -               EDOM_INFO(d)->long_block_tot,
> -               (EDOM_INFO(d)->long_block_tot * 100) / EDOM_INFO(d)->block_tot,
> -               (EDOM_INFO(d)->block_time_tot) / EDOM_INFO(d)->block_tot,
> -               (EDOM_INFO(d)->penalty_time_tot) / EDOM_INFO(d)->block_tot);
> +               EDOM_INFO(d)->stats.block_tot, EDOM_INFO(d)->stats.short_block_tot,
> +               (EDOM_INFO(d)->stats.short_block_tot * 100)
> +               / EDOM_INFO(d)->stats.block_tot, EDOM_INFO(d)->stats.short_cont,
> +               (EDOM_INFO(d)->stats.short_cont * 100) / EDOM_INFO(d)->stats.block_tot,
> +               EDOM_INFO(d)->stats.pen_extra_blocks,
> +               EDOM_INFO(d)->stats.pen_extra_slices,
> +               EDOM_INFO(d)->stats.long_block_tot,
> +               (EDOM_INFO(d)->stats.long_block_tot * 100) / EDOM_INFO(d)->stats.block_tot,
> +               (EDOM_INFO(d)->stats.block_time_tot) / EDOM_INFO(d)->stats.block_tot,
> +               (EDOM_INFO(d)->stats.penalty_time_tot) / EDOM_INFO(d)->stats.block_tot);

...wouldn't it be even more beautiful to have a macro for reading stats 
as well?

Like I said, it's fine as it is, but since you're looking for beauty, I 
figured I'd point it out. :-)

  -George