From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] MCE: support cpu notification chain Date: Thu, 25 Oct 2012 16:18:21 +0200 Message-ID: <50894A2D.8030007@amd.com> References: <5089449C.7020700@amd.com> <5089646102000078000A48DA@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5089646102000078000A48DA@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 10/25/12 16:10, Jan Beulich wrote: >>>> On 25.10.12 at 15:54, Christoph Egger wrote: >> Add support for cpu notification chain. >> This is useful with nested virtualization when Xen >> runs as l1 hypervisor. >> This cleans up mce initialization cleanup as a side-effect. > > Did you notice the fix I had done to your earlier patch before > committing c/s 26106:1883c1d29de9? With the change here, > mce_clear_banks will get allocated twice (once in generic code > and once in AMD specific code), leaking one instance. Ugh... must be a merge botch. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632