From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH 1/2] autoconf: check for wget and ftp Date: Tue, 30 Oct 2012 18:48:00 +0100 Message-ID: <509012D0.8030501@citrix.com> References: <1351588958-75040-1-git-send-email-roger.pau@citrix.com> <20623.60420.97632.890498@mariner.uk.xensource.com> <5090011D.9080406@citrix.com> <20624.3892.618566.138065@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20624.3892.618566.138065@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Christoph Egger , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 30/10/12 18:32, Ian Jackson wrote: > Roger Pau Monn=E9 writes ("Re: [Xen-devel] [PATCH 1/2] autoconf: check fo= r wget and ftp"): >> On 30/10/12 16:02, Ian Jackson wrote: >>> I don't think this can be right; wget is used in many more places. At >>> the very least it looks like it will break the stubdom build since >>> that is full of WGET. Did you grep for WGET ? >> >> Does stubdom build import config/Tools.mk? I thought it was only used to >> build the tools directory. If that's the case I don't think it will >> break anything, since we define a new variable $FETCHER, that shouldn't >> be used anywhere else, so the rest will continue to use the hardcoded >> wget, or whatever it was using prior to this patch. > = > Err, yes, it seems stubdom/Makefile has its own definition of wget. > But stubdom builds are still going to be broken without wget then ? Yes, but I don't think we should check for the requirements of stubdoms build process if we are not going to include config/Tools.mk to build them. For example NetBSD cannot build stubdoms (for other reasons), so we shouldn't enforce wget presence in configure.