From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 1 of 5] docs: document
	HYPERVISOR_update_va_mapping(_other_domain)
Date: Fri, 2 Nov 2012 11:33:57 +0000
Message-ID: <5093AFA5.4000107@citrix.com>
References: <patchbomb.1351855134@hastur.hellion.org.uk>
	<e8e1191aef208fbe2f4d.1351855135@hastur.hellion.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <e8e1191aef208fbe2f4d.1351855135@hastur.hellion.org.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 02/11/12 11:18, Ian Campbell wrote:
> docs: document HYPERVISOR_update_va_mapping(_other_domain)
> 
> Mark-up for inclusion of generated docs.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> diff -r 37a8946eeb9d -r e8e1191aef20 xen/include/public/xen.h
> --- a/xen/include/public/xen.h	Fri Oct 26 16:09:29 2012 +0100
> +++ b/xen/include/public/xen.h	Fri Nov 02 12:15:56 2012 +0100
> @@ -423,9 +423,25 @@ typedef struct mmuext_op mmuext_op_t;
>  DEFINE_XEN_GUEST_HANDLE(mmuext_op_t);
>  #endif
>  
> +/*
> + * ` enum neg_errnoval
> + * ` HYPERVISOR_update_va_mapping(unsigned long va, u64 val,
> + * `                              enum uvm_flags flags)
> + * `
> + * ` enum neg_errnoval
> + * ` HYPERVISOR_update_va_mapping_otherdomain(unsigned long va, u64 val,
> + * `                                          enum uvm_flags flags,
> + * `                                          domid_t domid)
> + * `
> + * ` @va: The virtual address whose mapping we want to change
> + * ` @val: The new page table entry

Suggest mentioning that this PTE requires the MFN not PFN.

David

> + * ` @flags: Control TLB flushes
> + */
> +*/
>  /* These are passed as 'flags' to update_va_mapping. They can be ORed. */
>  /* When specifying UVMF_MULTI, also OR in a pointer to a CPU bitmap.   */
>  /* UVMF_LOCAL is merely UVMF_MULTI with a NULL bitmap pointer.         */
> +/* ` enum uvm_flags { */
>  #define UVMF_NONE               (0UL<<0) /* No flushing at all.   */
>  #define UVMF_TLB_FLUSH          (1UL<<0) /* Flush entire TLB(s).  */
>  #define UVMF_INVLPG             (2UL<<0) /* Flush only one entry. */
> @@ -433,6 +449,7 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t);
>  #define UVMF_MULTI              (0UL<<2) /* Flush subset of TLBs. */
>  #define UVMF_LOCAL              (0UL<<2) /* Flush local TLB.      */
>  #define UVMF_ALL                (1UL<<2) /* Flush all TLBs.       */
> +/* ` } */
>  
>  /*
>   * Commands to HYPERVISOR_console_io().
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel