From: "Roger Pau Monné" <roger.pau@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen: restore GNTTABOP_dump_table
Date: Fri, 16 Nov 2012 16:02:09 +0100 [thread overview]
Message-ID: <50A65571.2060502@citrix.com> (raw)
In-Reply-To: <50A65338.2050002@citrix.com>
On 16/11/12 15:52, David Vrabel wrote:
> On 19/10/12 16:47, Roger Pau Monne wrote:
>> This operation was dropped long time ago, but I found it quite helpful
>> for debugging purposes. This re-implementation uses the code already
>> present in gnttab_usage_print and adds the maptrack-table dump.
>
> Why is the operation useful? Isn't the debug key sufficient?
The debug key doesn't print the maptrack, and also I found it quite
useful to be able to call this from the guest kernel itself at certain
specific points (like before and after cleaning the list of persistent
grants), which is not possible when using the debug key.
> # xl debug-key g
> (XEN) gnttab_usage_print_all [ key 'g' pressed
> (XEN) -------- active -------- -------- shared --------
> (XEN) [ref] localdom mfn pin localdom gmfn flags
> (XEN) grant-table for remote domain: 0 ... no active grant table entries
> (XEN) gnttab_usage_print_all ] done
>
> David
>
next prev parent reply other threads:[~2012-11-16 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 15:47 [PATCH] xen: restore GNTTABOP_dump_table Roger Pau Monne
2012-11-16 12:24 ` Roger Pau Monné
2012-11-16 14:52 ` David Vrabel
2012-11-16 15:02 ` Roger Pau Monné [this message]
2012-11-19 14:29 ` Ian Campbell
2012-11-19 14:38 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A65571.2060502@citrix.com \
--to=roger.pau@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).