From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, keir@xen.org, ian.campbell@citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH 3/5] xen: sysctl XSM hook removal
Date: Tue, 20 Nov 2012 10:34:47 -0500 [thread overview]
Message-ID: <50ABA317.70300@tycho.nsa.gov> (raw)
In-Reply-To: <50ABAF1302000078000AA0D5@nat28.tlf.novell.com>
On 11/20/2012 10:25 AM, Jan Beulich wrote:
>>>> On 20.11.12 at 15:51, Daniel De Graaf <dgdegra@tycho.nsa.gov> wrote:
>> A number of the sysctl XSM hooks have no parameters or only pass the
>> operation ID, making them redundant with the xsm_sysctl hook. Remove
>> these redundant hooks.
>>
>> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>> ---
>> xen/arch/x86/platform_hypercall.c | 12 ----
>
> This is slightly confusing given the title/description.
>
> Jan
>
There were a few hooks used in both sysctl and platform_hypercall, so this
was needed to avoid breaking the compile. I'll delay their removal until the
next patch in order to keep the changes confined to a single file, which was
my original goal.
--
Daniel De Graaf
National Security Agency
next prev parent reply other threads:[~2012-11-20 15:34 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 18:28 [PATCH v5] Merge IS_PRIV checks into XSM hooks Daniel De Graaf
2012-11-16 18:28 ` [PATCH 01/19] libxl: introduce XSM relabel on build Daniel De Graaf
2012-11-19 10:42 ` Ian Campbell
2012-11-20 16:38 ` Daniel De Graaf
2012-11-16 18:28 ` [PATCH 02/19] flask/policy: Add domain relabel example Daniel De Graaf
2012-11-19 10:46 ` Ian Campbell
2012-11-20 17:26 ` Daniel De Graaf
2012-11-16 18:28 ` [PATCH 03/19] arch/x86: add distinct XSM hooks for map/unmap Daniel De Graaf
2012-11-19 8:59 ` Jan Beulich
2012-11-19 14:53 ` Daniel De Graaf
2012-11-20 16:39 ` Jan Beulich
2012-11-16 18:28 ` [PATCH 04/19] xsm/flask: Add checks on the domain performing the set_target operation Daniel De Graaf
2012-11-16 18:28 ` [PATCH 05/19] xsm: Use the dummy XSM module if XSM is disabled Daniel De Graaf
2012-11-16 18:28 ` [PATCH 06/19] xen: use XSM instead of IS_PRIV where duplicated Daniel De Graaf
2012-11-19 9:08 ` Jan Beulich
2012-11-19 14:59 ` Daniel De Graaf
2012-11-19 15:43 ` Jan Beulich
2012-11-19 11:00 ` Ian Campbell
2012-11-19 15:16 ` Daniel De Graaf
2012-11-16 18:28 ` [PATCH 07/19] xen: avoid calling rcu_lock_*target_domain when an XSM hook exists Daniel De Graaf
2012-11-16 18:28 ` [PATCH 08/19] arch/x86: convert platform_hypercall to use XSM Daniel De Graaf
2012-11-16 18:28 ` [PATCH 09/19] xen: lock target domain in do_domctl common code Daniel De Graaf
2012-11-19 9:24 ` Jan Beulich
2012-11-19 15:20 ` Daniel De Graaf
2012-11-20 16:40 ` Jan Beulich
2012-11-20 16:44 ` Daniel De Graaf
2012-11-20 16:53 ` Jan Beulich
2012-11-16 18:28 ` [PATCH 10/19] xen: convert do_domctl to use XSM Daniel De Graaf
2012-11-16 18:28 ` [PATCH 11/19] xen: convert do_sysctl " Daniel De Graaf
2012-11-16 18:28 ` [PATCH 12/19] xsm/flask: add missing hooks Daniel De Graaf
2012-11-16 18:28 ` [PATCH 13/19] xsm/flask: add distinct SIDs for self/target access Daniel De Graaf
2012-11-16 18:28 ` [PATCH 14/19] arch/x86: Add missing mem_sharing XSM hooks Daniel De Graaf
2012-11-16 18:28 ` [PATCH 15/19] arch/x86: use XSM hooks for get_pg_owner access checks Daniel De Graaf
2012-11-16 18:28 ` [PATCH 16/19] xen: Add XSM hook for XENMEM_exchange Daniel De Graaf
2012-11-16 18:28 ` [PATCH 17/19] tmem: add XSM hooks Daniel De Graaf
2012-11-16 18:28 ` [PATCH 18/19] xen/arch/*: add struct domain parameter to arch_do_domctl Daniel De Graaf
2012-11-16 18:28 ` [PATCH 19/19] flask: move policy headers into hypervisor Daniel De Graaf
2012-11-19 9:45 ` [PATCH v5] Merge IS_PRIV checks into XSM hooks Jan Beulich
2012-11-19 10:26 ` Tim Deegan
2012-11-19 15:49 ` Daniel De Graaf
2012-11-19 21:28 ` [PATCH RFC 0/5] XSM hook renames and cleanup Daniel De Graaf
2012-11-19 21:28 ` [PATCH 1/5] Remove XSM_DEFAULT macro Daniel De Graaf
2012-11-19 21:28 ` [PATCH 2/5] xen: domctl XSM hook removal Daniel De Graaf
2012-11-19 21:28 ` [PATCH 3/5] xen: sysctl " Daniel De Graaf
2012-11-19 21:28 ` [PATCH 4/5] xen: platform_hypercall " Daniel De Graaf
2012-11-19 21:28 ` [PATCH RFC 5/5] xen/xsm: include default hook action in name Daniel De Graaf
2012-11-20 8:07 ` [PATCH RFC 0/5] XSM hook renames and cleanup Jan Beulich
2012-11-20 14:51 ` Daniel De Graaf
2012-11-20 14:51 ` [PATCH 1/5] Remove XSM_DEFAULT macro Daniel De Graaf
2012-11-20 14:51 ` [PATCH 2/5] xen: domctl XSM hook removal Daniel De Graaf
2012-11-20 15:15 ` Jan Beulich
2012-11-20 14:51 ` [PATCH 3/5] xen: sysctl " Daniel De Graaf
2012-11-20 15:25 ` Jan Beulich
2012-11-20 15:34 ` Daniel De Graaf [this message]
2012-11-20 14:51 ` [PATCH 4/5] xen: platform_hypercall " Daniel De Graaf
2012-11-20 14:51 ` [PATCH RFC 5/5] xen/xsm: include default hook action in name Daniel De Graaf
2012-11-22 16:57 ` Tim Deegan
2012-11-23 16:42 ` Daniel De Graaf
2012-11-27 14:49 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ABA317.70300@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).